You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "guofei (JIRA)" <ji...@apache.org> on 2019/07/10 06:38:00 UTC
[jira] [Updated] (MNG-6704) MavenRepositorySystemUtils.newSession()
unnecessary code
[ https://issues.apache.org/jira/browse/MNG-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
guofei updated MNG-6704:
------------------------
Description:
`new ChainedDependencyGraphTransformer` seems make no sense here.
{code:java}
public static DefaultRepositorySystemSession newSession()
{
// ...
DependencyGraphTransformer transformer =
new ConflictResolver( new NearestVersionSelector(), new JavaScopeSelector(),
new SimpleOptionalitySelector(), new JavaScopeDeriver() );
// seems unnecessary
new ChainedDependencyGraphTransformer( transformer, new JavaDependencyContextRefiner() );
session.setDependencyGraphTransformer( transformer );
// ...
}
{code}
was:
{code:java}
public static DefaultRepositorySystemSession newSession()
{
// ...
DependencyGraphTransformer transformer =
new ConflictResolver( new NearestVersionSelector(), new JavaScopeSelector(),
new SimpleOptionalitySelector(), new JavaScopeDeriver() );
// seems unnecessary
new ChainedDependencyGraphTransformer( transformer, new JavaDependencyContextRefiner() );
session.setDependencyGraphTransformer( transformer );
// ...
}
{code}
> MavenRepositorySystemUtils.newSession() unnecessary code
> ---------------------------------------------------------
>
> Key: MNG-6704
> URL: https://issues.apache.org/jira/browse/MNG-6704
> Project: Maven
> Issue Type: Improvement
> Reporter: guofei
> Priority: Trivial
>
> `new ChainedDependencyGraphTransformer` seems make no sense here.
> {code:java}
> public static DefaultRepositorySystemSession newSession()
> {
> // ...
> DependencyGraphTransformer transformer =
> new ConflictResolver( new NearestVersionSelector(), new JavaScopeSelector(),
> new SimpleOptionalitySelector(), new JavaScopeDeriver() );
> // seems unnecessary
> new ChainedDependencyGraphTransformer( transformer, new JavaDependencyContextRefiner() );
> session.setDependencyGraphTransformer( transformer );
> // ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)