You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/23 13:13:06 UTC
[GitHub] [inlong] boatrainlsz opened a new pull request, #4759: [INLONG-4758][Doc] Remove leading $ sign in README.md
boatrainlsz opened a new pull request, #4759:
URL: https://github.com/apache/inlong/pull/4759
- Fixes #4758
### Motivation
In convenience of coping and pasting for users, command line codes in READEME should remove leading $ sign.
### Modifications
Removed leading $ sign in README.md
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #4759: [INLONG-4758][Doc] Remove leading $ sign in README.md
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #4759:
URL: https://github.com/apache/inlong/pull/4759#issuecomment-1165159109
@boatrainlsz thanks.
1, do not need open and close PR when you update the commit.
2, "$" means normal users can execute this command. we can merge it for a convenient ‘copy’.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] boatrainlsz commented on pull request #4759: [INLONG-4758][Doc] Remove leading $ sign in README.md
Posted by GitBox <gi...@apache.org>.
boatrainlsz commented on PR #4759:
URL: https://github.com/apache/inlong/pull/4759#issuecomment-1165163567
> @boatrainlsz thanks. 1, do not need open and close PR when you update the commit. 2, "$" means normal users can execute this command. we can merge it for a convenient ‘copy’.
thanks for your advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] boatrainlsz closed pull request #4759: [INLONG-4758][Doc] Remove leading $ sign in README.md
Posted by GitBox <gi...@apache.org>.
boatrainlsz closed pull request #4759: [INLONG-4758][Doc] Remove leading $ sign in README.md
URL: https://github.com/apache/inlong/pull/4759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] boatrainlsz commented on a diff in pull request #4759: [INLONG-4758][Doc] Remove leading $ sign in README.md
Posted by GitBox <gi...@apache.org>.
boatrainlsz commented on code in PR #4759:
URL: https://github.com/apache/inlong/pull/4759#discussion_r905674559
##########
README.md:
##########
@@ -7,9 +7,9 @@
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
-
+
Review Comment:
> Thanks for your contribution. But, why add those blanks here?
sorry about that, it was accidently added, I will remove it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #4759: [INLONG-4758][Doc] Remove leading $ sign in README.md
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4759:
URL: https://github.com/apache/inlong/pull/4759#discussion_r905669609
##########
README.md:
##########
@@ -7,9 +7,9 @@
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
-
+
Review Comment:
Thanks for your contribution.
But, why add those blanks here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #4759: [INLONG-4758][Doc] Remove leading $ sign in README.md
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4759:
URL: https://github.com/apache/inlong/pull/4759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org