You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/02/04 05:44:27 UTC
Re: Review Request 30593: DRILL-2151:
VariableLengthVector.copyFromSafe() unnecessary sets the offsetVector
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30593/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 4:44 a.m.)
Review request for drill.
Summary (updated)
-----------------
DRILL-2151: VariableLengthVector.copyFromSafe() unnecessary sets the offsetVector
Bugs: DRILL-2151
https://issues.apache.org/jira/browse/DRILL-2151
Repository: drill-git
Description
-------
emoved the line
offsetVector.getMutator().setSafe( (thisIndex+1) * ${type.width}, outputStart + len);
from *VariableLengthVector.copyFromSafe()*
and refactored the call to *from.offsetVector.getAccessor()* to reuse the result.
Diffs
-----
exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java aa5b702
Diff: https://reviews.apache.org/r/30593/diff/
Testing
-------
all unit tests pass
"Functional - Passing - new" passes on 171
the query described in DRILL-2151 runs fine now
I'm still waiting for 57 to test "TPCH SF100 Parquet"
Thanks,
abdelhakim deneche
Re: Review Request 30593: DRILL-2151:
VariableLengthVector.copyFromSafe() unnecessary sets the offsetVector
Posted by Chris Westin <ch...@gmail.com>.
> On Feb. 4, 2015, 11:50 a.m., Chris Westin wrote:
> > Ship It!
Not that my vote counts yet....
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30593/#review71025
-----------------------------------------------------------
On Feb. 4, 2015, 8:42 a.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30593/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 8:42 a.m.)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-2151
> https://issues.apache.org/jira/browse/DRILL-2151
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> emoved the line
>
> offsetVector.getMutator().setSafe( (thisIndex+1) * ${type.width}, outputStart + len);
>
> from *VariableLengthVector.copyFromSafe()*
>
> and refactored the call to *from.offsetVector.getAccessor()* to reuse the result.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java aa5b702
>
> Diff: https://reviews.apache.org/r/30593/diff/
>
>
> Testing
> -------
>
> all unit tests pass
> "Functional - Passing - new" passes on 171
> "Advanced TPCH SF100" passes on 57
> the query described in DRILL-2151 runs fine now
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 30593: DRILL-2151:
VariableLengthVector.copyFromSafe() unnecessary sets the offsetVector
Posted by Chris Westin <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30593/#review71025
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Westin
On Feb. 4, 2015, 8:42 a.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30593/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 8:42 a.m.)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-2151
> https://issues.apache.org/jira/browse/DRILL-2151
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> emoved the line
>
> offsetVector.getMutator().setSafe( (thisIndex+1) * ${type.width}, outputStart + len);
>
> from *VariableLengthVector.copyFromSafe()*
>
> and refactored the call to *from.offsetVector.getAccessor()* to reuse the result.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java aa5b702
>
> Diff: https://reviews.apache.org/r/30593/diff/
>
>
> Testing
> -------
>
> all unit tests pass
> "Functional - Passing - new" passes on 171
> "Advanced TPCH SF100" passes on 57
> the query described in DRILL-2151 runs fine now
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 30593: DRILL-2151:
VariableLengthVector.copyFromSafe() unnecessary sets the offsetVector
Posted by abdelhakim deneche <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30593/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 4:42 p.m.)
Review request for drill.
Bugs: DRILL-2151
https://issues.apache.org/jira/browse/DRILL-2151
Repository: drill-git
Description
-------
emoved the line
offsetVector.getMutator().setSafe( (thisIndex+1) * ${type.width}, outputStart + len);
from *VariableLengthVector.copyFromSafe()*
and refactored the call to *from.offsetVector.getAccessor()* to reuse the result.
Diffs
-----
exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java aa5b702
Diff: https://reviews.apache.org/r/30593/diff/
Testing (updated)
-------
all unit tests pass
"Functional - Passing - new" passes on 171
"Advanced TPCH SF100" passes on 57
the query described in DRILL-2151 runs fine now
Thanks,
abdelhakim deneche