You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2022/03/31 14:47:56 UTC

[plc4x] 03/10: fix(protocol/test): Changed the checksum fields to actually call checksum functions

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git

commit 18ea08e06b3ca70d00dc210b6017d2a27af9ae57
Author: cdutz <ch...@c-ware.de>
AuthorDate: Thu Mar 31 16:42:47 2022 +0200

    fix(protocol/test): Changed the checksum fields to actually call checksum functions
---
 .../plc4go/internal/plc4go/test/readwrite/model/StaticHelper.go   | 8 ++++++++
 .../protocol-test/src/main/resources/protocols/test/test.mspec    | 8 ++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/code-generation/language-go/src/test/resources/plc4go/internal/plc4go/test/readwrite/model/StaticHelper.go b/code-generation/language-go/src/test/resources/plc4go/internal/plc4go/test/readwrite/model/StaticHelper.go
index 10e695c..def83ca 100644
--- a/code-generation/language-go/src/test/resources/plc4go/internal/plc4go/test/readwrite/model/StaticHelper.go
+++ b/code-generation/language-go/src/test/resources/plc4go/internal/plc4go/test/readwrite/model/StaticHelper.go
@@ -80,3 +80,11 @@ func Serialize(io utils.WriteBuffer, data byte) {
 func ReadManualField(io utils.ReadBuffer, simpleField uint8) (uint8, error) {
 	return 0, nil
 }
+
+func CrcInt8(num int) (int8, error) {
+	return int8(num), nil
+}
+
+func CrcUint8(num int) (uint8, error) {
+	return uint8(num), nil
+}
diff --git a/code-generation/protocol-test/src/main/resources/protocols/test/test.mspec b/code-generation/protocol-test/src/main/resources/protocols/test/test.mspec
index 1f2c2c4..2636ed4 100644
--- a/code-generation/protocol-test/src/main/resources/protocols/test/test.mspec
+++ b/code-generation/protocol-test/src/main/resources/protocols/test/test.mspec
@@ -38,7 +38,7 @@
     [array          uint 8  arrayFieldLength     length     '5'   ]
     [array          uint 8  arrayFieldTerminated terminated 'true']
     [assert         uint 8  assertField          '42'             ]
-    [checksum       uint 8  checksumField        '100'            ]
+    [checksum       uint 8  checksumField        'STATIC_CALL("crcUint8" , -23)']
     [const          uint 8  constField           5                ]
     // Discriminated Field can't be used in simple type
     //[discriminator  uint 8  discriminatorField]
@@ -68,7 +68,7 @@
     //Abstract fields can only be used within discriminated base types.
     //[abstract       unit 8  abstractField]
     [array          uint 8  arrayField        count      '5']
-    [checksum       uint 8  checksumField     '100']
+    [checksum       uint 8  checksumField     'STATIC_CALL("crcUint8" , -23)']
     [const          uint 8  constField        5]
     // Discriminated Field can't be used in simple type
     //[discriminator  uint 8  discriminatorField]
@@ -146,8 +146,8 @@
 
 [type CheckSumTypeTest
     //Bit field cannot be used for a checksum: [checksum bit bitField 'true']
-    [checksum int 8 intField '100']
-    [checksum uint 8 uintField '100']
+    [checksum int 8  intField  'STATIC_CALL("crcInt8" , -23)']
+    [checksum uint 8 uintField 'STATIC_CALL("crcUint8", 42)']
     // Float fields cannot be used as checksums: [checksum float 32 floatField '100.0']
     // Float fields cannot be used as checksums: [checksum float 64 doubleField '100.0']
     // String field cannot be used as a checksum: [checksum vstring '11 * 8' stringField '"HELLO TODDY"']