You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/10/07 04:07:56 UTC
[GitHub] [rocketmq] medusar opened a new pull request #2336: [ISSUE# 2325] Use CopyOnWriteArrayList to avoid possible thread safety issues.
medusar opened a new pull request #2336:
URL: https://github.com/apache/rocketmq/pull/2336
## What is the purpose of the change
Use `CopyOnWriteArrayList` to avoid thread safety issues.
## Brief changelog
replace `Vector` with `CopyOnWriteArrayList<>()` and remove useless imports.
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2336: [ISSUE# 2325] Use CopyOnWriteArrayList to avoid possible thread safety issues.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2336:
URL: https://github.com/apache/rocketmq/pull/2336#issuecomment-704682080
[](https://coveralls.io/builds/33984253)
Coverage decreased (-0.06%) to 51.377% when pulling **b1f69b7e900ecd0f226854008a262a59f5bd236a on medusar:develop** into **f58dbc3edaf7d4136a0e3e0cd90d6f3a58198957 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #2336: [ISSUE# 2325] Use CopyOnWriteArrayList to avoid possible thread safety issues.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2336:
URL: https://github.com/apache/rocketmq/pull/2336#issuecomment-704685775
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2336?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@f58dbc3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/2336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2336 +/- ##
==========================================
Coverage ? 45.60%
Complexity ? 4283
==========================================
Files ? 547
Lines ? 35971
Branches ? 4770
==========================================
Hits ? 16406
Misses ? 17506
Partials ? 2059
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/rocketmq/broker/out/BrokerOuterAPI.java](https://codecov.io/gh/apache/rocketmq/pull/2336/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvb3V0L0Jyb2tlck91dGVyQVBJLmphdmE=) | `46.47% <100.00%> (ø)` | `12.00 <3.00> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2336?src=pr&el=footer). Last update [f58dbc3...b1f69b7](https://codecov.io/gh/apache/rocketmq/pull/2336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #2336: [ISSUE# 2325] Use CopyOnWriteArrayList to avoid possible thread safety issues.
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #2336:
URL: https://github.com/apache/rocketmq/pull/2336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org