You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2013/04/27 16:44:49 UTC
svn commit: r1476593 - in
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4:
bag/ collection/ list/ queue/ set/
Author: tn
Date: Sat Apr 27 14:44:48 2013
New Revision: 1476593
URL: http://svn.apache.org/r1476593
Log:
ignore false-positive from pmd
Modified:
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedBag.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedSortedBag.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/collection/TransformedCollection.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TransformedList.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/queue/TransformedQueue.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSet.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSortedSet.java
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedBag.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedBag.java?rev=1476593&r1=1476592&r2=1476593&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedBag.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedBag.java Sat Apr 27 14:44:48 2013
@@ -76,7 +76,7 @@ public class TransformedBag<E> extends T
final TransformedBag<E> decorated = new TransformedBag<E>(bag, transformer);
if (transformer != null && bag != null && bag.size() > 0) {
@SuppressWarnings("unchecked") // Bag is of type E
- final E[] values = (E[]) bag.toArray();
+ final E[] values = (E[]) bag.toArray(); // NOPMD - false positive for generics
bag.clear();
for (final E value : values) {
decorated.decorated().add(transformer.transform(value));
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedSortedBag.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedSortedBag.java?rev=1476593&r1=1476592&r2=1476593&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedSortedBag.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bag/TransformedSortedBag.java Sat Apr 27 14:44:48 2013
@@ -77,7 +77,7 @@ public class TransformedSortedBag<E> ext
final TransformedSortedBag<E> decorated = new TransformedSortedBag<E>(bag, transformer);
if (transformer != null && bag != null && bag.size() > 0) {
@SuppressWarnings("unchecked") // bag is type E
- final E[] values = (E[]) bag.toArray();
+ final E[] values = (E[]) bag.toArray(); // NOPMD - false positive for generics
bag.clear();
for (final E value : values) {
decorated.decorated().add(transformer.transform(value));
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/collection/TransformedCollection.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/collection/TransformedCollection.java?rev=1476593&r1=1476592&r2=1476593&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/collection/TransformedCollection.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/collection/TransformedCollection.java Sat Apr 27 14:44:48 2013
@@ -84,7 +84,7 @@ public class TransformedCollection<E> ex
// null collection & transformer are disallowed by the constructor call above
if (collection.size() > 0) {
@SuppressWarnings("unchecked") // collection is of type E
- final E[] values = (E[]) collection.toArray();
+ final E[] values = (E[]) collection.toArray(); // NOPMD - false positive for generics
collection.clear();
for (final E value : values) {
decorated.decorated().add(transformer.transform(value));
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TransformedList.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TransformedList.java?rev=1476593&r1=1476592&r2=1476593&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TransformedList.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TransformedList.java Sat Apr 27 14:44:48 2013
@@ -80,7 +80,7 @@ public class TransformedList<E> extends
final TransformedList<E> decorated = new TransformedList<E>(list, transformer);
if (transformer != null && list != null && list.size() > 0) {
@SuppressWarnings("unchecked") // list is of type E
- final E[] values = (E[]) list.toArray();
+ final E[] values = (E[]) list.toArray(); // NOPMD - false positive for generics
list.clear();
for (final E value : values) {
decorated.decorated().add(transformer.transform(value));
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/queue/TransformedQueue.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/queue/TransformedQueue.java?rev=1476593&r1=1476592&r2=1476593&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/queue/TransformedQueue.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/queue/TransformedQueue.java Sat Apr 27 14:44:48 2013
@@ -76,7 +76,7 @@ public class TransformedQueue<E> extends
final TransformedQueue<E> decorated = new TransformedQueue<E>(queue, transformer);
if (queue.size() > 0) {
@SuppressWarnings("unchecked") // queue is type <E>
- final E[] values = (E[]) queue.toArray();
+ final E[] values = (E[]) queue.toArray(); // NOPMD - false positive for generics
queue.clear();
for (final E value : values) {
decorated.decorated().add(transformer.transform(value));
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSet.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSet.java?rev=1476593&r1=1476592&r2=1476593&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSet.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSet.java Sat Apr 27 14:44:48 2013
@@ -76,7 +76,7 @@ public class TransformedSet<E> extends T
final TransformedSet<E> decorated = new TransformedSet<E>(set, transformer);
if (transformer != null && set != null && set.size() > 0) {
@SuppressWarnings("unchecked") // set is type E
- final E[] values = (E[]) set.toArray();
+ final E[] values = (E[]) set.toArray(); // NOPMD - false positive for generics
set.clear();
for (final E value : values) {
decorated.decorated().add(transformer.transform(value));
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSortedSet.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSortedSet.java?rev=1476593&r1=1476592&r2=1476593&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSortedSet.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/set/TransformedSortedSet.java Sat Apr 27 14:44:48 2013
@@ -78,7 +78,7 @@ public class TransformedSortedSet<E> ext
final TransformedSortedSet<E> decorated = new TransformedSortedSet<E>(set, transformer);
if (transformer != null && set != null && set.size() > 0) {
@SuppressWarnings("unchecked") // set is type E
- final E[] values = (E[]) set.toArray();
+ final E[] values = (E[]) set.toArray(); // NOPMD - false positive for generics
set.clear();
for (final E value : values) {
decorated.decorated().add(transformer.transform(value));