You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mrinalsharma (via GitHub)" <gi...@apache.org> on 2023/04/25 17:00:02 UTC
[GitHub] [camel-karavan] mrinalsharma opened a new issue, #749: Allow user to upload a jar file.
mrinalsharma opened a new issue, #749:
URL: https://github.com/apache/camel-karavan/issues/749
Camel-jbang version 4 has the ability to export a jar file in the project folder to the local lib folder. more details can be found at [camel-jbang](https://github.com/apache/camel-kamelets-examples/tree/main/jbang/local-jar) example
Add a UI feature in camel-karavn that can take a jar file and add it to the project.
Example camel-jbang command
```
jbang -Dcamel.jbang.version=4.0.0-SNAPSHOT camel@apache/camel export --runtime=spring-boot --gav=com.foo:acme:1.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #749: Allow user to upload a jar file.
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1522216065
Export as a maven project has already implemented in Karavan VS Code extension
<img width="415" alt="Screenshot 2023-04-25 at 2 11 48 PM" src="https://user-images.githubusercontent.com/1379213/234366339-e04b2b91-6065-4e56-a4dc-0e28c367998d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #749: Allow user to upload a jar file.
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1522219221
Karavan aimed to have the same experience in VS Code extension and in Cloud App.
Both work with code in Git repo. Actually the best practice is to keep projet code in Git repo.
External dependencies should be configured in `camel.jbang.dependencies` property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #749: Allow user to upload a jar file.
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1522437688
1. Rare case and Very bad practice.
2. Has workaround: copy jar somewhere, add to `camel.jbang.dependencies`, click `Karavan:export`
No reason to implement already legacy and bad practice approach in newly created tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mrinalsharma closed issue #749: Allow user to upload a jar file.
Posted by "mrinalsharma (via GitHub)" <gi...@apache.org>.
mrinalsharma closed issue #749: Allow user to upload a jar file.
URL: https://github.com/apache/camel-karavan/issues/749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #749: Allow user to upload a jar file.
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1522213209
@mrinalsharma could you please what are you trying to do?
1. Add jar file to the route as described in the https://github.com/apache/camel-kamelets-examples/tree/main/jbang/local-jar ?
2. Export project as maven using `jbang camel export`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mrinalsharma commented on issue #749: Allow user to upload a jar file.
Posted by "mrinalsharma (via GitHub)" <gi...@apache.org>.
mrinalsharma commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1522126434
you can assign this to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] davsclaus commented on issue #749: Allow user to upload a jar file.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1527082532
> understood, but in practice, not all projects follow best practices.. some projects have legacy code whose artifacts are not in maven and libraries are stored in source controls. These libraries are added as file dependencies.
>
> Also, sometimes the dependent library is not fully developed to be published in public or private maven, there should still be an option for users to try and test the logic in such a library. giving only the repository option, user is forced to finish their library work first and publish to Maven. Then only he can consume. This creates serialization of work and teams don't like serializing work. What if user just has a stub API in the library initially from another team. They will publish the library later once it's tested.
Yeah that was also one of the reasons for the local JAR feature in jbang. IMHO allowing users to just drop what they need in the same folder, and then let jbang figure out how to run this, and export nicely into working maven/gradle based projects that can be used to continue, and also for jenkins/ci-cd pipelines to build and deploy from there.
All in total making Karavan and Camel more approachable to users that want a quick and easy way to build small integrations and for users that need to prototype "stuff".
I would like to consider reopening this and be able to offer this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mrinalsharma commented on issue #749: Allow user to upload a jar file.
Posted by "mrinalsharma (via GitHub)" <gi...@apache.org>.
mrinalsharma commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1522283149
my brain dump:
- The user is working on a project and creates a library. This library is not promoted to Maven
- He/she wants to use the logic in the library as part of the camel route.
- So, there should be an ability for him to upload the library and add it to his project in git.
- When the user deploys the project in Kubernetes, camel-jbang export the project as maven and copies the jar file to /lib folder( This is supported in camel-jbabg 4.0)
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #749: Allow user to upload a jar file.
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1522317634
Library is not promoted to Maven - this is very bad practice. Project build is not reproducible.
Karavan aimes to provide best practices. Karavan VS Code and Cloud app should work same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mrinalsharma commented on issue #749: Allow user to upload a jar file.
Posted by "mrinalsharma (via GitHub)" <gi...@apache.org>.
mrinalsharma commented on issue #749:
URL: https://github.com/apache/camel-karavan/issues/749#issuecomment-1522351544
understood, but in practice, not all projects follow best practices.. some projects have legacy code whose artifacts are not in maven and libraries are stored in source controls. These libraries are added as file dependencies.
Also, sometimes the dependent library is not fully developed to be published in public or private maven, there should still be an option for users to try and test the logic in such a library. giving only the repository option, user is forced to finish their library work first and publish to Maven. Then only he can consume. This creates serialization of work and teams don't like serializing work.
What if user just has a stub API in the library initially from another team. They will publish the library later once it's tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org