[GitHub] [commons-imaging] garydgregory commented on pull request #278: (Ref) #8 refactored decode image in order to reduce Cyclomatic

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on PR #278:
URL: https://github.com/apache/commons-imaging/pull/278#issuecomment-1435423300

   This might satisfy some static code analysis but it's -1 for me since this PR now wastes memory allocating and building a List every single time. A bad trade off IMO.
   
   To make this even worth, the PR also looses a code comment. Was this code change machine generated? That often happens with machine transforms.
   
   What do others think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[Imaging] PR #278: [...] reduce Cyclomatic

[Gilles Sadowski <gi...@gmail.com>]

Le sam. 18 févr. 2023 à 01:33, garydgregory (via GitHub)
<gi...@apache.org> a écrit :
>
>
> garydgregory commented on PR #278:
> URL: https://github.com/apache/commons-imaging/pull/278#issuecomment-1435423300
>
>    This might satisfy some static code analysis but it's -1 for me since this PR now wastes memory allocating and building a List every single time. A bad trade off IMO.
>
>    To make this even worth, the PR also looses a code comment. Was this code change machine generated? That often happens with machine transforms.
>
>    What do others think?

Shouldn't it be a "switch"?

Regards,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org