You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Isaac Chiang <is...@gmail.com> on 2013/05/01 17:49:06 UTC
Review Request: CLOUDSTACK-2178 : "Add guest network" button is not
responding
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10882/
-----------------------------------------------------------
Review request for cloudstack and Pranav Saxena.
Description
-------
The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn field correctly.
Changed :
1. Dialog.js : Modify makeForm function in Dialog.js to work correctly with "dependsOn" field.
2. Network.js : Add checking for response in the call back function.
This addresses bug CLOUDSTACK-2178.
Diffs
-----
ui/scripts/network.js 9ba725a
ui/scripts/ui/dialog.js bb372fb
Diff: https://reviews.apache.org/r/10882/diff/
Testing
-------
Test from ui ans work well
Thanks,
Isaac Chiang
RE: Review Request: CLOUDSTACK-2178 : "Add guest network" button is
not responding
Posted by Animesh Chaturvedi <an...@citrix.com>.
Pranav
Can you review the updated patch and submit if it is good to go
Animesh
> -----Original Message-----
> From: Isaac Chiang [mailto:noreply@reviews.apache.org] On Behalf Of
> Isaac Chiang
> Sent: Friday, May 10, 2013 12:37 AM
> To: Pranav Saxena
> Cc: cloudstack; Isaac Chiang
> Subject: Re: Review Request: CLOUDSTACK-2178 : "Add guest network"
> button is not responding
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10882/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 7:37 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Changes
> -------
>
> Patch updated
>
>
> Description
> -------
>
> The root cause of the issue is that the makeForm function in dialog.js
> cannot work with dependsOn field correctly.
>
> Changed :
> 1. Dialog.js : Modify makeForm function in Dialog.js to work
> correctly with "dependsOn" field.
> 2. Network.js : Add checking for response in the call back function.
>
>
> This addresses bug CLOUDSTACK-2178.
>
>
> Diffs (updated)
> -----
>
> ui/scripts/network.js 6b310ce
> ui/scripts/ui/dialog.js bb372fb
>
> Diff: https://reviews.apache.org/r/10882/diff/
>
>
> Testing
> -------
>
> Test from ui ans work well
>
>
> Thanks,
>
> Isaac Chiang
Re: Review Request: CLOUDSTACK-2178 : "Add guest network" button is not
responding
Posted by Isaac Chiang <is...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10882/
-----------------------------------------------------------
(Updated May 10, 2013, 7:37 a.m.)
Review request for cloudstack and Pranav Saxena.
Changes
-------
Patch updated
Description
-------
The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn field correctly.
Changed :
1. Dialog.js : Modify makeForm function in Dialog.js to work correctly with "dependsOn" field.
2. Network.js : Add checking for response in the call back function.
This addresses bug CLOUDSTACK-2178.
Diffs (updated)
-----
ui/scripts/network.js 6b310ce
ui/scripts/ui/dialog.js bb372fb
Diff: https://reviews.apache.org/r/10882/diff/
Testing
-------
Test from ui ans work well
Thanks,
Isaac Chiang
Re: Review Request 10882: CLOUDSTACK-2178 : "Add guest network" button is
not responding
Posted by Saksham Srivastava <sa...@citrix.com>.
> On May 4, 2013, 8:48 p.m., Pranav Saxena wrote:
> > Review comment on the corresponding JIRA ticket to verify if its actually a valid bug . If yes , then we'll definitely proceed with validating the fix . Thanks !
Hi Issac, CLOUDSTACK-2178 is marked closed as invalid.
Do we still need this fix ? If no then you can discard this review request.
- Saksham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10882/#review20169
-----------------------------------------------------------
On May 10, 2013, 7:37 a.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10882/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 7:37 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Bugs: CLOUDSTACK-2178
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn field correctly.
>
> Changed :
> 1. Dialog.js : Modify makeForm function in Dialog.js to work correctly with "dependsOn" field.
> 2. Network.js : Add checking for response in the call back function.
>
>
> Diffs
> -----
>
> ui/scripts/network.js 6b310ce
> ui/scripts/ui/dialog.js bb372fb
>
> Diff: https://reviews.apache.org/r/10882/diff/
>
>
> Testing
> -------
>
> Test from ui ans work well
>
>
> Thanks,
>
> Isaac Chiang
>
>
Re: Review Request: CLOUDSTACK-2178 : "Add guest network" button is not
responding
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10882/#review20169
-----------------------------------------------------------
Review comment on the corresponding JIRA ticket to verify if its actually a valid bug . If yes , then we'll definitely proceed with validating the fix . Thanks !
- Pranav Saxena
On May 1, 2013, 3:49 p.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10882/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 3:49 p.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn field correctly.
>
> Changed :
> 1. Dialog.js : Modify makeForm function in Dialog.js to work correctly with "dependsOn" field.
> 2. Network.js : Add checking for response in the call back function.
>
>
> This addresses bug CLOUDSTACK-2178.
>
>
> Diffs
> -----
>
> ui/scripts/network.js 9ba725a
> ui/scripts/ui/dialog.js bb372fb
>
> Diff: https://reviews.apache.org/r/10882/diff/
>
>
> Testing
> -------
>
> Test from ui ans work well
>
>
> Thanks,
>
> Isaac Chiang
>
>