[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1382: MINIFICPP-1899 - Fix local Docker build failure

[GitBox <gi...@apache.org>]

martinzink commented on code in PR #1382:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1382#discussion_r938707263


##########
libminifi/src/utils/BackTrace.cpp:
##########
@@ -54,8 +54,10 @@ namespace {
 }  // namespace
 #endif
 
+#ifndef HAS_EXECINFO
+void pull_trace(uint8_t) {
+#else  // HAS_EXECINFO
 void pull_trace(uint8_t frames_to_skip /* = 1 */) {

Review Comment:
   I think we can avoid these ifndef-s and (void) workarounds with the new [C++ attribute: maybe_unused (since C++17)](https://en.cppreference.com/w/cpp/language/attributes/maybe_unused)
   ```suggestion
   void pull_trace([[maybe_unused]] uint8_t frames_to_skip /* = 1 */) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org