You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "feiyx (via GitHub)" <gi...@apache.org> on 2023/09/25 04:01:48 UTC
[GitHub] [spark] feiyx opened a new pull request, #43089: [SPARK-37508][SQL] Add Unicode[encode/decode]() function
feiyx opened a new pull request, #43089:
URL: https://github.com/apache/spark/pull/43089
### What changes were proposed in this pull request?
Currently, Spark don't support unicode encode/decode as built-in functions, the usermight use reflect instead ,
It's a bit of poor efficiency ,And often these functions are useful.
### Why are the changes needed?
unicode encode/decode functions are useful in SQL statistics
### Does this PR introduce _any_ user-facing change?
yes, add new function as built-in function
### How was this patch tested?
add new tests yet
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-37508][SQL] Add Unicode[encode/decode]() function [spark]
Posted by "feiyx (via GitHub)" <gi...@apache.org>.
feiyx commented on PR #43089:
URL: https://github.com/apache/spark/pull/43089#issuecomment-1752520536
> We have UDFs that is relatively easy for users to implement actually. I wouldn't add this unless it's quite common enough that other DBMSes have.
I iknow. like urlencode/urldecod in hive method，unicode is very versatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #43089: [SPARK-37508][SQL] Add Unicode[encode/decode]() function
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43089:
URL: https://github.com/apache/spark/pull/43089#issuecomment-1733380817
We have UDFs that is relatively easy for users to implement actually. I wouldn't add this unless it's quite common enough that other DBMSes have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-37508][SQL] Add Unicode[encode/decode]() function [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43089:
URL: https://github.com/apache/spark/pull/43089#issuecomment-1897542367
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-37508][SQL] Add Unicode[encode/decode]() function [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #43089: [SPARK-37508][SQL] Add Unicode[encode/decode]() function
URL: https://github.com/apache/spark/pull/43089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #43089: [SPARK-37508][SQL] Add Unicode[encode/decode]() function
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43089:
URL: https://github.com/apache/spark/pull/43089#issuecomment-1733003061
Do you happen to have any reference for these functions in other DBMSes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] feiyx commented on pull request #43089: [SPARK-37508][SQL] Add Unicode[encode/decode]() function
Posted by "feiyx (via GitHub)" <gi...@apache.org>.
feiyx commented on PR #43089:
URL: https://github.com/apache/spark/pull/43089#issuecomment-1733320033
> Do you happen to have any reference for these functions in other DBMSes?
in other db can be implemented in other ways,However, it can be very complicated, and it can be a burden for users
https://stackoverflow.com/questions/11062330/mysql-decode-unicode-to-utf-8-function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org