You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/05 01:14:15 UTC
[GitHub] [skywalking-java] Oliverwqcwrw opened a new pull request, #139: Fix typo and optimize UT
Oliverwqcwrw opened a new pull request, #139:
URL: https://github.com/apache/skywalking-java/pull/139
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094042909
<img width="462" alt="image" src="https://user-images.githubusercontent.com/5441976/162578396-7f730670-1092-45a3-935e-dcb43bdba72b.png">
You changed this. I think you did it locally, but you didn't know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094043088
When you merge with the upstream, and submodule changed, your git may say something changed, you should reset it rather than submitting the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1088574547
I have nothing to modify, please check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094154918
Ok,I will move these modified files to another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw closed pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw closed pull request #139: Fix typo and optimize UT
URL: https://github.com/apache/skywalking-java/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842692709
##########
apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/define/DelegatingConnectionInstrumentation.java:
##########
@@ -29,8 +29,7 @@
import static org.apache.skywalking.apm.agent.core.plugin.match.NameMatch.byName;
/**
- * DBCP use DelegatingConnection which is the delegating implementation of Connection.All of
- * the methods from the Connection interface simply check to see that the Connection is active.
+ * DBCP use DelegatingConnection which is the delegating implementation of Connection.All the methods from the Connection interface simply check to see that the Connection is active.
Review Comment:
Don't reformat the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094159713
I have moved these changes to #148 ,so I will close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842297026
##########
apm-application-toolkit/apm-toolkit-micrometer-registry/src/main/java/org/apache/skywalking/apm/meter/micrometer/SkywalkingDistributionSummary.java:
##########
@@ -47,7 +47,7 @@
private final Counter sum;
/**
- * Max amount in this summary
+ * MaxAmount in this summary
Review Comment:
You can change it to whatever you feel is more appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842300476
##########
apm-application-toolkit/apm-toolkit-micrometer-registry/src/main/java/org/apache/skywalking/apm/meter/micrometer/SkywalkingDistributionSummary.java:
##########
@@ -47,7 +47,7 @@
private final Counter sum;
/**
- * Max amount in this summary
+ * MaxAmount in this summary
Review Comment:
All right, let me undo it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1088226279
> I am holding this PR to make more of your chore fixes to be merged in one pull request.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094044141
Can this PR be merged now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1088225290
I am holding this PR to make more of your chore fixes to be merged in one pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842294743
##########
apm-application-toolkit/apm-toolkit-micrometer-registry/src/main/java/org/apache/skywalking/apm/meter/micrometer/SkywalkingDistributionSummary.java:
##########
@@ -47,7 +47,7 @@
private final Counter sum;
/**
- * Max amount in this summary
+ * MaxAmount in this summary
Review Comment:
But your changes are using two different styles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094152946
You could copy required files into your another PR if you have to.
I am not using git command, most using SourceCodes, so, don't know what is your local issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842299046
##########
apm-application-toolkit/apm-toolkit-micrometer-registry/src/main/java/org/apache/skywalking/apm/meter/micrometer/SkywalkingDistributionSummary.java:
##########
@@ -47,7 +47,7 @@
private final Counter sum;
/**
- * Max amount in this summary
+ * MaxAmount in this summary
Review Comment:
Personally, I prefer don't change this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw closed pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw closed pull request #139: Fix typo and optimize UT
URL: https://github.com/apache/skywalking-java/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842698197
##########
apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/define/DelegatingConnectionInstrumentation.java:
##########
@@ -29,8 +29,7 @@
import static org.apache.skywalking.apm.agent.core.plugin.match.NameMatch.byName;
/**
- * DBCP use DelegatingConnection which is the delegating implementation of Connection.All of
- * the methods from the Connection interface simply check to see that the Connection is active.
+ * DBCP use DelegatingConnection which is the delegating implementation of Connection.All the methods from the Connection interface simply check to see that the Connection is active.
Review Comment:
ok,I will change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094147182
My localhost exec `git -c protocol.version=2 submodule update --init --force --depth=1` is no problem
> Submodule path 'apm-protocol/apm-network/src/main/proto': checked out '8095caa8a003cd2acd3a8a5f1d0e1739dc177ce6'
But why there appears the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094047051
You need to rollback the submodule. I think this is very basic skill of git, you should try to learn it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#issuecomment-1094049157
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842270041
##########
apm-application-toolkit/apm-toolkit-micrometer-registry/src/main/java/org/apache/skywalking/apm/meter/micrometer/SkywalkingDistributionSummary.java:
##########
@@ -47,7 +47,7 @@
private final Counter sum;
/**
- * Max amount in this summary
+ * MaxAmount in this summary
Review Comment:
I think it's a little clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842268204
##########
apm-application-toolkit/apm-toolkit-micrometer-registry/src/main/java/org/apache/skywalking/apm/meter/micrometer/SkywalkingDistributionSummary.java:
##########
@@ -47,7 +47,7 @@
private final Counter sum;
/**
- * Max amount in this summary
+ * MaxAmount in this summary
Review Comment:
What does this mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Oliverwqcwrw commented on a diff in pull request #139: Fix typo and optimize UT
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #139:
URL: https://github.com/apache/skywalking-java/pull/139#discussion_r842295479
##########
apm-application-toolkit/apm-toolkit-micrometer-registry/src/main/java/org/apache/skywalking/apm/meter/micrometer/SkywalkingDistributionSummary.java:
##########
@@ -47,7 +47,7 @@
private final Counter sum;
/**
- * Max amount in this summary
+ * MaxAmount in this summary
Review Comment:
Sorry,I didn't catch your meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org