[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #91: [Performance Optimization] Improve the speed of writing index file in shuffle server

[GitBox <gi...@apache.org>]

zuston commented on code in PR #91:
URL: https://github.com/apache/incubator-uniffle/pull/91#discussion_r930962262


##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/LocalFileWriter.java:
##########
@@ -34,7 +35,7 @@ public class LocalFileWriter implements Closeable {
   public LocalFileWriter(File file) throws IOException {
     fileOutputStream = new FileOutputStream(file, true);
     // init fsDataOutputStream
-    dataOutputStream = new DataOutputStream(fileOutputStream);
+    dataOutputStream = new DataOutputStream(new BufferedOutputStream(fileOutputStream));

Review Comment:
   From the flamegraph, i dont found this problem. But for the rule of minor change, i think we should make this change only for write index. What do u think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org