You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2017/09/19 08:51:01 UTC
[jira] [Commented] (FELIX-5685) Splitting configadmin into
configadmin and file persistance bundle
[ https://issues.apache.org/jira/browse/FELIX-5685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171336#comment-16171336 ]
Carsten Ziegeler commented on FELIX-5685:
-----------------------------------------
[~fhoelting] I've created FELIX-5693 with a different proposal which is more user friendly as it will not break most of the config admin users. But it should give you the same result
> Splitting configadmin into configadmin and file persistance bundle
> ------------------------------------------------------------------
>
> Key: FELIX-5685
> URL: https://issues.apache.org/jira/browse/FELIX-5685
> Project: Felix
> Issue Type: Improvement
> Components: Configuration Admin
> Affects Versions: configadmin-1.8.16
> Reporter: Frank Hölting
> Labels: patch
> Attachments: Splitting-configadmin-into-configadmin-and-file-pers.patch
>
>
> It allows you to start alternative PersistenceManager without using
> Service Ranking and OSGi Start Level. The dependency definition of the
> declarative services is the only one that decides when which
> service/bundle is to be started.
> Unfortunately, the tests do not work before refactoring. Class not found
> exception by org. osgi.* Classes. This seems to be due to the maven pom
> configuration. And thus a fundamental test error of the bundle?
> Where can I find the CI system. At https://builds.apache.org/ you can find some felix subprojects. But not the Felix root project or even the configadmin subproject. It would be helpful to know how to run the tests if it doesn't work with mvn clean install.
> TODO:
> - Execute all tests
> - use code Formatter
> In the documentary SVN is documented as SCM. However, there is also a Felix github project. I have attached a git patch. I also like to create a pull request of the fork https://github.com/jcommand/felix/commits/trunk. Here are the two new commits.
> 716043a - The suggestion for improvement - patch and fork
> 1e7beab - same fixes of the build, see comment and code - only fork
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Re: [jira] [Commented] (FELIX-5685) Splitting configadmin into
configadmin and file persistance bundle
Posted by Carsten Ziegeler <cz...@apache.org>.
Frank Hölting wrote
> Hi,
>
> i suspect that the 1... n possible PersitenceManager is an unused option. There would have to be several configuration sources for this, e. g. DB, File or SCM. In my opinion, there should be only one PersistenceManager service registration at runtime.
Yes, I forgot to mention this in the issue. It might be sufficient to
just support a single PM.
>
> However, since I cannot speak for everyone, the proposal is acceptable.
>
> The list is then passed by e.g. -Dfelix.pm=a,b of the Configuration Admin implementation? I wonder how the Configuration Admin reacts to the service registration sequence.
>
> Example:
> -Dfelix.pm=a,b
> Case 1: The service registration has the sequence "b", "a"
> Case 2: Only "b" is registered.
>
> In case 1: Does the CA implementation wait until PersistenceManager "a" is registered?
Yes.
> In case 2. Will it wait forever or will a timeout be implemented?
It will wait forever as the requirements are not satisfied.
>
> If I'm not mistaken, the current implementation can only use one PersistenceManager for the active saving of the component configuration. The PersistenceManager with the highest service ranging is allowed to store.
> If PersistenceManager "a" is not available, will "b" be saved? Is "a" then present again, then the wrong configuration is provided? Multiple dynamic configuration sources are not easy to manage.
Totally agree with that. So maybe we just go with a single PM. It's
easier to handle, easier to understand and easier to implement.
Thanks
Carsten
>
> For my specific case -Dfelix. pm=a is fine.
>
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: [jira] [Commented] (FELIX-5685) Splitting configadmin into
configadmin and file persistance bundle
Posted by Frank Hölting <sa...@athlete-grip.com>.
Hi,
i suspect that the 1... n possible PersitenceManager is an unused option. There would have to be several configuration sources for this, e. g. DB, File or SCM. In my opinion, there should be only one PersistenceManager service registration at runtime.
However, since I cannot speak for everyone, the proposal is acceptable.
The list is then passed by e.g. -Dfelix.pm=a,b of the Configuration Admin implementation? I wonder how the Configuration Admin reacts to the service registration sequence.
Example:
-Dfelix.pm=a,b
Case 1: The service registration has the sequence "b", "a"
Case 2: Only "b" is registered.
In case 1: Does the CA implementation wait until PersistenceManager "a" is registered?
In case 2. Will it wait forever or will a timeout be implemented?
If I'm not mistaken, the current implementation can only use one PersistenceManager for the active saving of the component configuration. The PersistenceManager with the highest service ranging is allowed to store.
If PersistenceManager "a" is not available, will "b" be saved? Is "a" then present again, then the wrong configuration is provided? Multiple dynamic configuration sources are not easy to manage.
For my specific case -Dfelix. pm=a is fine.
Thank you very much
Frank Hölting
> "Carsten Ziegeler (JIRA)" <ji...@apache.org> hat am 19. September 2017 um 10:51 geschrieben:
>
>
>
> [ https://issues.apache.org/jira/browse/FELIX-5685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171336#comment-16171336 ]
>
> Carsten Ziegeler commented on FELIX-5685:
> -----------------------------------------
>
> [~fhoelting] I've created FELIX-5693 with a different proposal which is more user friendly as it will not break most of the config admin users. But it should give you the same result
>
> > Splitting configadmin into configadmin and file persistance bundle
> > ------------------------------------------------------------------
> >
> > Key: FELIX-5685
> > URL: https://issues.apache.org/jira/browse/FELIX-5685
> > Project: Felix
> > Issue Type: Improvement
> > Components: Configuration Admin
> > Affects Versions: configadmin-1.8.16
> > Reporter: Frank Hölting
> > Labels: patch
> > Attachments: Splitting-configadmin-into-configadmin-and-file-pers.patch
> >
> >
> > It allows you to start alternative PersistenceManager without using
> > Service Ranking and OSGi Start Level. The dependency definition of the
> > declarative services is the only one that decides when which
> > service/bundle is to be started.
> > Unfortunately, the tests do not work before refactoring. Class not found
> > exception by org. osgi.* Classes. This seems to be due to the maven pom
> > configuration. And thus a fundamental test error of the bundle?
> > Where can I find the CI system. At https://builds.apache.org/ you can find some felix subprojects. But not the Felix root project or even the configadmin subproject. It would be helpful to know how to run the tests if it doesn't work with mvn clean install.
> > TODO:
> > - Execute all tests
> > - use code Formatter
> > In the documentary SVN is documented as SCM. However, there is also a Felix github project. I have attached a git patch. I also like to create a pull request of the fork https://github.com/jcommand/felix/commits/trunk. Here are the two new commits.
> > 716043a - The suggestion for improvement - patch and fork
> > 1e7beab - same fixes of the build, see comment and code - only fork
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.4.14#64029)
>