You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "liwei (Jira)" <ji...@apache.org> on 2020/10/20 16:46:00 UTC

[jira] [Commented] (HUDI-857) Overhaul unit-tests for Cleaner and ROllbacks

    [ https://issues.apache.org/jira/browse/HUDI-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217750#comment-17217750 ] 

liwei commented on HUDI-857:
----------------------------

[~vbalaji] hi, i am interested about this. But have some questions:

about cleaner  ,is TestCleaner.java  not clearly?  

about rollback ,is TestCopyOnWriteRollbackActionExecutor、 TestMergeOnReadRollbackActionExecutor? 

can you help to point out specific unit test?

"Instead some of them seem to be written to make them pass with the initial code"

 

i am not clear about this.  Thanks :)

> Overhaul unit-tests for Cleaner and ROllbacks
> ---------------------------------------------
>
>                 Key: HUDI-857
>                 URL: https://issues.apache.org/jira/browse/HUDI-857
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: Common Core
>            Reporter: Balaji Varadarajan
>            Priority: Major
>              Labels: help-requested
>             Fix For: 0.6.1
>
>
> Unit tests for these components do not clearly tests their functionality. Instead some of them seem to be written to make them pass with the initial code. We would need to overhaul these tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)