[GitHub] cjolivier01 commented on a change in pull request #7903: Refactor AdaGrad optimizer to support sparse tensors + unary and binary refactoring for new infer storage type logic

[gi...@git.apache.org]

cjolivier01 commented on a change in pull request #7903: Refactor AdaGrad optimizer to support sparse tensors + unary and binary refactoring for new infer storage type logic
URL: https://github.com/apache/incubator-mxnet/pull/7903#discussion_r143831685
 
 

 ##########
 File path: src/common/utils.h
 ##########
 @@ -63,6 +63,36 @@ inline bool ContainsOnlyStorage(const StorageTypeVector& vstorage,
   return false;
 }
 
+/*! \brief returns true if all storage types in `vstorage` are the same as target `stype1`
+ *         or `stype2'. Sets boolean if both found.
+ *         false is returned for empty inputs.
+ */
+inline bool ContainsOnlyStorage(const StorageTypeVector& vstorage,
 
 Review comment:
   The new design may check a lot of permutations of inputs/outputs in order to make the decision to fall back or not.  This is the foundation of the new infer storage type design which is already in master.  Not sure what the expectation is in that case.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services