You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/05/28 08:45:57 UTC
[PR] CAMEL-23629: camel-irc - align Exchange header constant names with Camel naming convention [camel]
oscerd opened a new pull request, #23594:
URL: https://github.com/apache/camel/pull/23594
## Motivation
Renames the Exchange header string values in `IrcConstants` from the non-Camel-prefixed `irc.*` namespace to the project-wide `CamelIrc*` PascalCase convention, following the umbrella tracker [CAMEL-23577](https://issues.apache.org/jira/browse/CAMEL-23577) and matching the pattern shipped for the sibling components: `camel-jira` (CAMEL-23576), `camel-dns` (CAMEL-23574), `camel-mongodb-gridfs` (CAMEL-23575), `camel-web3j` (CAMEL-23578), `camel-pdf` (CAMEL-23579), `camel-openstack` (CAMEL-23580), `camel-elasticsearch` / `camel-opensearch` (CAMEL-23581), `camel-github2` (CAMEL-23582), `camel-arangodb` (CAMEL-23585), `camel-jt400` (CAMEL-23587), `camel-undertow` (CAMEL-23588), `camel-milo` (CAMEL-23590), `camel-shiro` (CAMEL-23592) and `camel-solr` (CAMEL-23597).
Jira: https://issues.apache.org/jira/browse/CAMEL-23629
## Constants renamed
| Constant | Previous value | New value |
|---|---|---|
| `IrcConstants.IRC_MESSAGE_TYPE` | `irc.messageType` | `CamelIrcMessageType` |
| `IrcConstants.IRC_TARGET` | `irc.target` | `CamelIrcTarget` |
| `IrcConstants.IRC_SEND_TO` | `irc.sendTo` | `CamelIrcSendTo` |
| `IrcConstants.IRC_USER_KICKED` | `irc.user.kicked` | `CamelIrcUserKicked` |
| `IrcConstants.IRC_USER_HOST` | `irc.user.host` | `CamelIrcUserHost` |
| `IrcConstants.IRC_USER_NICK` | `irc.user.nick` | `CamelIrcUserNick` |
| `IrcConstants.IRC_USER_SERVERNAME` | `irc.user.servername` | `CamelIrcUserServername` |
| `IrcConstants.IRC_USER_USERNAME` | `irc.user.username` | `CamelIrcUserUsername` |
| `IrcConstants.IRC_NUM` | `irc.num` | `CamelIrcNum` |
| `IrcConstants.IRC_VALUE` | `irc.value` | `CamelIrcValue` |
## Compatibility
The Java field names are unchanged, so routes that reference the constants symbolically (`header(IrcConstants.IRC_SEND_TO)`, `setHeader(IrcConstants.IRC_TARGET, ...)`, etc.) continue to work without modification. Routes that set or read the headers by their literal `irc.*` string value must be updated to use the new `CamelIrc*` values — documented in the 4.21 upgrade guide as a "potential breaking change" with the rename table and the cross-transport `HeaderFilterStrategy` behaviour note used by the sibling sub-tasks.
> Note: `camel-irc` was deprecated in 4.21 (the upstream `irclib` has had no stable release since 2007) but still ships in 4.20.x, the 4.18.x LTS and the 4.14.x LTS lines. The rename will be backported to 4.18.x and 4.14.x as part of the CAMEL-23577 sweep.
## Changes
- `IrcConstants.java` — string values of all 10 header constants.
- `IrcConfiguration.java` — `setNamesOnJoin` Javadoc reference to the `CamelIrcNum` header.
- Integration tests `IrcPrivmsgIT`, `IrcMultiChannelRouteIT`, `IrcsListUsersIT` — switched from literal `irc.*` strings to `IrcConstants` symbolic references.
- `irc-component.adoc` — message-header table and example route references.
- Regenerated component-local catalog (`components/camel-irc/src/generated/.../irc.json`) and top-level catalog (`catalog/camel-catalog/src/generated/.../irc.json`).
- 4.21 upgrade guide entry "camel-irc - potential breaking change" with rename table, before/after snippet and cross-transport propagation note.
## Local build
`mvn clean install -DskipTests -Dquickly` from the worktree root — green (8081 goals, 6331 executed, 1750 cached). Module `mvn -DskipTests install` in `components/camel-irc/` regenerated the artifacts and the top-level catalog mirror updated correctly on the full reactor run.
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23629: camel-irc - align Exchange header constant names with Camel naming convention [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23594:
URL: https://github.com/apache/camel/pull/23594#issuecomment-4563305546
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `catalog/camel-catalog`
- `components/camel-irc`
- `docs`
- `dsl/camel-endpointdsl`
<details><summary>All tested modules (10 modules)</summary>
- Camel :: Catalog :: Camel Catalog
- Camel :: Endpoint DSL
- Camel :: IRC (deprecated)
- Camel :: JBang :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Validate
- Camel :: Launcher :: Container
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26566224255)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23629: camel-irc - align Exchange header constant names with Camel naming convention [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #23594:
URL: https://github.com/apache/camel/pull/23594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23629: camel-irc - align Exchange header constant names with Camel naming convention [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23594:
URL: https://github.com/apache/camel/pull/23594#issuecomment-4562266642
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org