svn commit: r1480543 - /tomee/tomee/trunk/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/Setup.java

[db...@apache.org]

Author: dblevins
Date: Thu May  9 07:19:58 2013
New Revision: 1480543

URL: http://svn.apache.org/r1480543
Log:
Note on a potential bug and some tests we should write

Modified:
    tomee/tomee/trunk/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/Setup.java

Modified: tomee/tomee/trunk/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/Setup.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/Setup.java?rev=1480543&r1=1480542&r2=1480543&view=diff
==============================================================================
--- tomee/tomee/trunk/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/Setup.java (original)
+++ tomee/tomee/trunk/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/Setup.java Thu May  9 07:19:58 2013
@@ -67,6 +67,14 @@ public class Setup {
         final File serverXml = Files.path(tomeeHome, "conf", "server.xml");
         final QuickServerXmlParser ports = QuickServerXmlParser.parse(serverXml);
 
+        /* DMB: TODO - Looks like there's a bug here.  We should add some tests for our server.xml manipulation
+           This will work fine with the default ports, but if someone should update their ports to say
+           http="111", https="1111" and stop="11111", then someone updates just the http port to "444"
+           .. the resulting ports will mistakenly be 444, 4441, and 44411 respectively.
+
+           We really should add some tests for comparing server.xml files before and after, as well as
+           have a few different server.xml files with non-standard settings.
+         */
         final Map<String, String> replacements = new HashMap<String, String>();
         replacements.put(ports.http(), String.valueOf(configuration.getHttpPort()));
         replacements.put(ports.stop(), String.valueOf(configuration.getStopPort()));