You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jonbuffington <gi...@git.apache.org> on 2015/08/18 00:27:33 UTC
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
GitHub user jonbuffington opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/221
feat: use ZEPPELIN_HOSTNAME to specify hostname
ZEPPELIN_HOSTNAME supports running Zeppelin in environments where the
hostname of the server does not match the hostname delivered to the
browser. If ZEPPELIN_HOSTNAME is not set, java.net.InetAddress.
getLocalHost().getHostName() is still used to lookup the server's
current hostname.
NotebookServerTests was renamed to NotebookServerTest to permit the
test cases to run using Maven's test goal.
Fixes https://issues.apache.org/jira/browse/ZEPPELIN-231
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fuseelements/incubator-zeppelin WIP-hostname-env
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #221
----
commit 336c49e4d2efe227c7e5425f378646a703d96962
Author: Jon Buffington <jo...@fuseelements.com>
Date: 2015-08-17T21:13:16Z
feat: use ZEPPELIN_HOSTNAME to specify hostname
ZEPPELIN_HOSTNAME supports running Zeppelin in environments where the
hostname of the server does not match the hostname delivered to the
browser. If ZEPPELIN_HOSTNAME is not set, java.net.InetAddress.
getLocalHost().getHostName() is still used to lookup the server's
current hostname.
NotebookServerTests was renamed to NotebookServerTest to permit the
test cases to run using Maven's test goal.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by djoelz <gi...@git.apache.org>.
Github user djoelz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-132305160
@jonbuffington what @Leemoonsoo said. Let me know if you need any help with this as I am responsable for the issue :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by jonbuffington <gi...@git.apache.org>.
Github user jonbuffington commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-132611409
@Leemoonsoo Thanks for the pointers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by djoelz <gi...@git.apache.org>.
Github user djoelz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-132615855
@jonbuffington @Leemoonsoo don't worry guys I will make the fix. Will create a separate PR.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by jonbuffington <gi...@git.apache.org>.
Github user jonbuffington commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-132245845
Appreciate the feedback. Do you have any guidance on using ZeppelinConfiguration instead of an environment variable? I implemented ZEPPELIN_HOSTNAME as an environment variable to ease packaging in a docker image.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-132270605
This is where you can define your variable in ZeppelinConfiguration
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L369
This is how to read the variable
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by jonbuffington <gi...@git.apache.org>.
Github user jonbuffington commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-133364295
I am closing this in favor of #235.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by djoelz <gi...@git.apache.org>.
Github user djoelz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-131988406
Thanks for fixing my bug :)
I would prefer this setting live in the ZeppelinConfiguration class and not in an environment variable. This way it is discoverable by anyone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by jonbuffington <gi...@git.apache.org>.
Github user jonbuffington closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-133209304
The same issue is also being taken care of, by #235.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: feat: use ZEPPELIN_HOSTNAME to sp...
Posted by jonbuffington <gi...@git.apache.org>.
Github user jonbuffington commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/221#issuecomment-132610892
@djoelz Unfortunately, I am booked till this weekend. If you would like to make the changes, it would be appreciated,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---