You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@mesos.apache.org by "Benjamin Mahler (JIRA)" <ji...@apache.org> on 2015/09/24 21:30:04 UTC

[jira] [Created] (MESOS-3512) Don't retry close() on EINTR.

Benjamin Mahler created MESOS-3512:
--------------------------------------

             Summary: Don't retry close() on EINTR.
                 Key: MESOS-3512
                 URL: https://issues.apache.org/jira/browse/MESOS-3512
             Project: Mesos
          Issue Type: Bug
            Reporter: Benjamin Mahler
            Assignee: Benjamin Mahler


On Linux, retrying close on EINTR is dangerous because the fd is already released and we may accidentally close a newly opened fd (from another thread), see:

http://ewontfix.com/4/
http://lwn.net/Articles/576478/
http://lwn.net/Articles/576591/

It appears that other OSes, like HPUX, require a retry of close on EINTR. The Austin Group recently proposed changes to POSIX to require that the EINTR case need a retry, but EINPROGRESS be used for when a retry should not occur:

http://austingroupbugs.net/view.php?id=529

However, Linux does not follow this and so we need to remove our EINTR retries.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)