You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Ellis <er...@apache.org> on 2019/02/25 07:37:40 UTC
[VOTE] Cordova-Electron 1.0.0 Release
Please review and vote on this Electron Release v1.0.0
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://github.com/apache/cordova/issues/10
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/GH-10
The package was published from its corresponding git tag:
cordova-electron: 1.0.0 (b6dc52124e)
Note that you can test it out via:
cordova platform add https://github.com/apache/cordova-electron#1.0.0
Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post.
Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Test
Re: [VOTE] Cordova-Electron 1.0.0 Release
Posted by Bryan Ellis <el...@gmail.com>.
The vote has now closed. The results are:
Positive Binding Votes: 3
* Bryan Ellis
* Jesse
* M Gearóid
Negative Binding Votes: 0
The vote has passed.
From: M Gearóid <de...@gearoid.me> <de...@gearoid.me>
Reply: dev@cordova.apache.org <de...@cordova.apache.org>
<de...@cordova.apache.org>
Date: February 26, 2019 at 21:39:30
To: dev@cordova.apache.org <de...@cordova.apache.org> <de...@cordova.apache.org>
Subject: Re: [VOTE] Cordova-Electron 1.0.0 Release
+1
* added to existing app, builds and runs
* npm test
* npm audit
On Tue, 26 Feb 2019, at 01:44, Jesse wrote:
> +1
> * coho verify-archive
> * CI green
> * npm test
> * npm audit
> * coho check-license
>
> @purplecabbage
> risingj.com
>
>
> On Sun, Feb 24, 2019 at 11:37 PM Bryan Ellis <er...@apache.org> wrote:
>
> > Please review and vote on this Electron Release v1.0.0
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://github.com/apache/cordova/issues/10
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/GH-10
> >
> > The package was published from its corresponding git tag:
> > cordova-electron: 1.0.0 (b6dc52124e)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-electron#1.0.0
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> >
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Test
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [VOTE] Cordova-Electron 1.0.0 Release
Posted by Gearóid M <de...@gearoid.me>.
+1
* added to existing app, builds and runs
* npm test
* npm audit
On Tue, 26 Feb 2019, at 01:44, Jesse wrote:
> +1
> * coho verify-archive
> * CI green
> * npm test
> * npm audit
> * coho check-license
>
> @purplecabbage
> risingj.com
>
>
> On Sun, Feb 24, 2019 at 11:37 PM Bryan Ellis <er...@apache.org> wrote:
>
> > Please review and vote on this Electron Release v1.0.0
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://github.com/apache/cordova/issues/10
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/GH-10
> >
> > The package was published from its corresponding git tag:
> > cordova-electron: 1.0.0 (b6dc52124e)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-electron#1.0.0
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Test
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [VOTE] Cordova-Electron 1.0.0 Release
Posted by Jesse <pu...@gmail.com>.
+1
* coho verify-archive
* CI green
* npm test
* npm audit
* coho check-license
@purplecabbage
risingj.com
On Sun, Feb 24, 2019 at 11:37 PM Bryan Ellis <er...@apache.org> wrote:
> Please review and vote on this Electron Release v1.0.0
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://github.com/apache/cordova/issues/10
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/GH-10
>
> The package was published from its corresponding git tag:
> cordova-electron: 1.0.0 (b6dc52124e)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-electron#1.0.0
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Test
>
>