You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/08 15:54:52 UTC

[GitHub] [kafka] dengziming commented on a change in pull request #11638: MINOR: enable KRaft in DeleteTopicsRequestTest

dengziming commented on a change in pull request #11638:
URL: https://github.com/apache/kafka/pull/11638#discussion_r780680670



##########
File path: core/src/test/scala/unit/kafka/server/AbstractCreateTopicsRequestTest.scala
##########
@@ -162,7 +162,7 @@ abstract class AbstractCreateTopicsRequestTest extends BaseRequestTest {
   protected def validateErrorCreateTopicsRequests(request: CreateTopicsRequest,
                                                   expectedResponse: Map[String, ApiError],
                                                   checkErrorMessage: Boolean = true): Unit = {
-    val response = sendCreateTopicRequest(request, createTopicsSocketServer)

Review comment:
       Since we have replaced `createTopicsSocketServer` with `adminSocketServer`, can we remove the unused `createTopicsSocketServer` method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org