You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/13 03:37:29 UTC
[GitHub] [apisix] tzssangglass opened a new pull request, #7901: change: move config_center to deployment and named as config_provider
tzssangglass opened a new pull request, #7901:
URL: https://github.com/apache/apisix/pull/7901
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7901: change: move config_center under deployment and named as config_provider
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7901:
URL: https://github.com/apache/apisix/pull/7901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7901: change: move config_center under deployment and named as config_provider
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7901:
URL: https://github.com/apache/apisix/pull/7901#discussion_r971671487
##########
docs/en/latest/stand-alone.md:
##########
@@ -34,13 +34,15 @@ The routing rules in the `conf/apisix.yaml` file are loaded into memory immediat
Since the current Admin API is based on the etcd configuration center solution, enable Admin API is not allowed when the Stand-alone mode is enabled.
-To enable Stand-alone mode, we can set `apisix.config_center` to `yaml` and disable Admin API in file `conf/config.yaml`.
+The Stand-alone mode can only be enabled when set the role of APISIX as data plane. We can set `deployment.role` to `data_plane` and `deployment.role_data_plane.config_provider` to `yaml`, and also need to disable Admin API in file `conf/config.yaml`.
Review Comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7901: change: move config_center under deployment and named as config_provider
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7901:
URL: https://github.com/apache/apisix/pull/7901#discussion_r971621484
##########
docs/en/latest/stand-alone.md:
##########
@@ -34,13 +34,15 @@ The routing rules in the `conf/apisix.yaml` file are loaded into memory immediat
Since the current Admin API is based on the etcd configuration center solution, enable Admin API is not allowed when the Stand-alone mode is enabled.
-To enable Stand-alone mode, we can set `apisix.config_center` to `yaml` and disable Admin API in file `conf/config.yaml`.
+The Stand-alone mode can only be enabled when set the role of APISIX as data plane. We can set `deployment.role` to `data_plane` and `deployment.role_data_plane.config_provider` to `yaml`, and also need to disable Admin API in file `conf/config.yaml`.
Review Comment:
When we set `deployment.role` to `data_plane`, the admin API is disabled automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] sober-wang commented on pull request #7901: change: move config_center under deployment and named as config_provider
Posted by GitBox <gi...@apache.org>.
sober-wang commented on PR #7901:
URL: https://github.com/apache/apisix/pull/7901#issuecomment-1336810640
this pr is merged, but apisix repo version is v2.15.1 .
<img width="1253" alt="图片" src="https://user-images.githubusercontent.com/35804630/205563714-b88fc0bf-671b-44e2-872b-21c02a0c4a46.png">
can you tell me how to use the `apisix.config_center: yaml` config .
Just learning apisix , and create a etcd 3 node caluster , it looks a little complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #7901: change: move config_center under deployment and named as config_provider
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on PR #7901:
URL: https://github.com/apache/apisix/pull/7901#issuecomment-1337128510
> 此 pr 已合并，但 apisix repo 版本为 v2.15.1
v2.15.1 no need to be concerned about changes to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org