You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/18 03:07:07 UTC
[GitHub] [incubator-tvm] merrymercy opened a new pull request #6935: [AutoScheduler] Improve warning messages
merrymercy opened a new pull request #6935:
URL: https://github.com/apache/incubator-tvm/pull/6935
Improve the warning messages for #6903
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6935: [AutoScheduler] Improve warning messages
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #6935:
URL: https://github.com/apache/incubator-tvm/pull/6935#discussion_r525703690
##########
File path: python/tvm/relay/op/strategy/cuda.py
##########
@@ -224,7 +231,7 @@ def conv2d_strategy_cuda(attrs, inputs, out_type, target):
if use_auto_scheduler and judge_winograd_auto_scheduler:
strategy.add_implementation(
wrap_compute_conv2d(topi.nn.conv2d_winograd_nhwc),
- wrap_topi_schedule(tvm.te.create_schedule),
+ naive_schedule, # this implementation should never be picked by autotvm
Review comment:
`tvm.te.create_schedule` is not a valid topi schedule. Their signatures are different. So I created a new one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6935: [AutoScheduler] Improve warning messages
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6935:
URL: https://github.com/apache/incubator-tvm/pull/6935#discussion_r525860346
##########
File path: python/tvm/relay/op/strategy/cuda.py
##########
@@ -101,6 +101,17 @@ def schedule_lrn_cuda(attrs, outs, target):
return topi.cuda.schedule_lrn(outs)
+def naive_schedule(_, outs, target):
+ """Return the naive default schedule"""
+ if "gpu" in target.keys:
+ # For GPU, we at least need thread binding to make a valid schedule.
+ # So the naive schedule cannot be compiled.
+ raise RuntimeError(
+ "Cannot compile for GPU targets if no tuned schedule is found. Please see the warning messages above for more information about the failed workloads."
+ )
+ return tvm.te.create_schedule(outs[-1].op)
Review comment:
Maybe we need to add a comment saying that it would be a problem for the DAG with multiple outputs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy merged pull request #6935: [AutoScheduler] Improve warning messages
Posted by GitBox <gi...@apache.org>.
merrymercy merged pull request #6935:
URL: https://github.com/apache/incubator-tvm/pull/6935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6935: [AutoScheduler] Improve warning messages
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #6935:
URL: https://github.com/apache/incubator-tvm/pull/6935#discussion_r525703085
##########
File path: python/tvm/relay/op/strategy/cuda.py
##########
@@ -224,7 +231,7 @@ def conv2d_strategy_cuda(attrs, inputs, out_type, target):
if use_auto_scheduler and judge_winograd_auto_scheduler:
strategy.add_implementation(
wrap_compute_conv2d(topi.nn.conv2d_winograd_nhwc),
- wrap_topi_schedule(tvm.te.create_schedule),
Review comment:
`tvm.te.create_schedule` is not a valid topi schedule. Their signatures are different
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org