You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Radu Cotescu <ra...@apache.org> on 2015/03/23 11:03:09 UTC
[VOTE] Release Apache Sling Scripting Sightly 1.0.0
Hi,
We solved 54 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12329007 (44)
https://issues.apache.org/jira/browse/SLING/fixforversion/12329008 (10)
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1216
The staging repository contains the following artifacts:
org.apache.sling.scripting.sightly
org.apache.sling.scripting.sightly.js.provider
org.apache.sling.scripting.sightly.repl
org.apache.sling.scripting.sightly.testing
org.apache.sling.scripting.sightly.testing-content
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh 1216 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Justin Edelson <ju...@justinedelson.com>.
+1
On Mon, Mar 23, 2015 at 6:03 AM, Radu Cotescu <ra...@apache.org> wrote:
> Hi,
>
> We solved 54 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12329007 (44)
> https://issues.apache.org/jira/browse/SLING/fixforversion/12329008 (10)
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1216
>
> The staging repository contains the following artifacts:
>
> org.apache.sling.scripting.sightly
> org.apache.sling.scripting.sightly.js.provider
> org.apache.sling.scripting.sightly.repl
> org.apache.sling.scripting.sightly.testing
> org.apache.sling.scripting.sightly.testing-content
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1216 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Mar 24, 2015 at 9:48 PM, Radu Cotescu <ra...@apache.org> wrote:
> ...the vote should still go on for the artifacts from 1216....
Here's my +1 for the release of the below source archives.
Verified signatures, build and that the corresponding svn tags match.
-Bertrand
SHA1(org.apache.sling.scripting.sightly-1.0.0-source-release.zip)=
424b8dadf9754c25c9584aef2becc1f1eff107d2
SHA1(org.apache.sling.scripting.sightly.js.provider-1.0.0-source-release.zip)=
f13a8e87bc29fd6d77aa59fdf25e2bd1ab1dab23
SHA1(.org.apache.sling.scripting.sightly.repl-1.0.0-source-release.zip)=
b89ee3076e9808129a6022505b91b6ed00dd643c
SHA1(org.apache.sling.scripting.sightly.testing-content-1.0.0-source-release.zip)=
8476d5453ad857e36dcb9f8c838685a2b8ef86bc
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Robert Munteanu <ro...@apache.org>.
On Tue, 2015-03-24 at 22:48 +0200, Radu Cotescu wrote:
> Hi Robert,
>
> I'm fine with dropping the o.a.s.scripting.sightly.testing artifact from
> this release, in which case the vote should still go on for the artifacts
> from 1216.
Agreed, thanks for your patience with the process :-)
Here's my +1, based on the current state from the 1216 staging repo.
Robert
>
> I'll start a new release thread for o.a.s.scripting.sightly.testing once
> the o.a.s.performance.base artifact is released.
>
> Cheers,
> Radu
>
> On 24 March 2015 at 22:04, Robert Munteanu <ro...@apache.org> wrote:
>
> > IMO you should either drop org.apache.sling.scripting.sightly.testing
> > completely from this release or cancel the whole release and restart the
> > process once org.apache.sling.performance.base has been released.
> >
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Radu Cotescu <ra...@apache.org>.
Hi Robert,
I'm fine with dropping the o.a.s.scripting.sightly.testing artifact from
this release, in which case the vote should still go on for the artifacts
from 1216.
I'll start a new release thread for o.a.s.scripting.sightly.testing once
the o.a.s.performance.base artifact is released.
Cheers,
Radu
On 24 March 2015 at 22:04, Robert Munteanu <ro...@apache.org> wrote:
> IMO you should either drop org.apache.sling.scripting.sightly.testing
> completely from this release or cancel the whole release and restart the
> process once org.apache.sling.performance.base has been released.
>
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Robert Munteanu <ro...@apache.org>.
Hm, I still don't think this is correct.
On Mon, 2015-03-23 at 23:45 +0200, Radu Cotescu wrote:
> Hi Robert,
>
> 1216 contains:
> org.apache.sling.scripting.sightly
> org.apache.sling.scripting.sightly.js.provider
> org.apache.sling.scripting.sightly.repl
> org.apache.sling.scripting.sightly.testing-content
Ok.
>
> as I've removed org.apache.sling.scripting.sightly.testing, since it was
> pointing to a snapshot dependency.
>
> 1219 contains:
> org.apache.sling.scripting.sightly.testing, which now points to
> org.apache.sling.performance.base 1.0.2.
Well, there are two issues here:
- org.apache.sling.performance.base 1.0.2 is not released so you must
not reference it yet
- you've changed an artifact under vote
IMO you should either drop org.apache.sling.scripting.sightly.testing
completely from this release or cancel the whole release and restart the
process once org.apache.sling.performance.base has been released.
At any rate, it's not correct to change the artifacts under vote while
the vote is running.
I withdraw my vote until this issue is cleared.
Robert
>
> Thanks,
> Radu
>
>
>
> On Mon, Mar 23, 2015 at 11:37 PM, Robert Munteanu <ro...@lmn.ro> wrote:
>
> > On Mon, Mar 23, 2015 at 11:29 PM, Radu Cotescu <ra...@apache.org> wrote:
> > > Hi,
> > >
> > > I've started a release thread for org.apache.sling.performance.base at
> > > http://sling.markmail.org/thread/m7xyhb6saxfyqs6w.
> > >
> > > I've also dropped org.apache.sling.scripting.sightly.testing from staging
> > > repository 1216 and restaged this artifact at 1219.
> > >
> > > You can use this UNIX script to download the release and verify the
> > > signatures for org.apache.sling.scripting.sightly.testing:
> > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> > >
> > > Usage:
> > > sh check_staged_release.sh 1219 /tmp/sling-staging
> >
> > So on which repository/artifacts are we voting now? Both 1216 and 1219
> > seem to be active.
> >
> > Robert
> >
> > >
> > > Thanks,
> > > Radu
> > >
> > >
> > > On Mon, Mar 23, 2015 at 7:25 PM, Radu Cotescu <ra...@apache.org> wrote:
> > >
> > >> Hi Robert,
> > >>
> > >> It would be better to release that snapshot dependency in order to
> > >> provide a way to easily test Sightly artifacts.
> > >>
> > >> I'll take care of that this evening.
> > >>
> > >> Cheers,
> > >> Radu
> > >>
> > >>
> > >> On Monday, March 23, 2015, Robert Munteanu <ro...@apache.org> wrote:
> > >>
> > >>> On Mon, 2015-03-23 at 10:50 -0400, Daniel Klco wrote:
> > >>> > org.apache.sling.sightly.testing relies on a SNAPSHOT dependency:
> > >>> >
> > >>> > <dependency>
> > >>> > <groupId>org.apache.sling</groupId>
> > >>> >
> > <artifactId>org.apache.sling.performance.base</artifactId>
> > >>> > <version>0.0.1-SNAPSHOT</version>
> > >>> > <scope>test</scope>
> > >>> > </dependency>
> > >>> >
> > >>> > As this is a testing project, I'm not sure if this is a big deal or
> > >>> > acceptable. Ideally, if we could make a release of this performance
> > >>> > tools
> > >>> > it would be good to apply performance tests across all of the
> > >>> > scripting
> > >>> > languages available in Sling.
> > >>>
> > >>> Good catch! I assumed the maven release plugin would be banning
> > >>> SNAPSHOTs, but apparently this is not the case ...
> > >>>
> > >>> We can't deploy SNAPSHOT depedencies on Maven Central and we should not
> > >>> as a general rule depend on SNAPSHOTs from releases, as the SNAPSHOTs
> > >>> will at some point go away and make the released artifact invalid.
> > >>>
> > >>> So we either release the org.apache.sling.performance.base artifact and
> > >>> depend on it or drop the org.apache.sling.sightly.testing artifact from
> > >>> the release.
> > >>>
> > >>> Radu?
> > >>>
> > >>> Robert
> > >>>
> > >>>
> > >>>
> > >>
> > >> --
> > >> Sent with clumsy fingers from a touchscreen
> > >>
> >
> >
> >
> > --
> > Sent from my (old) computer
> >
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Radu Cotescu <ra...@apache.org>.
Hi Robert,
1216 contains:
org.apache.sling.scripting.sightly
org.apache.sling.scripting.sightly.js.provider
org.apache.sling.scripting.sightly.repl
org.apache.sling.scripting.sightly.testing-content
as I've removed org.apache.sling.scripting.sightly.testing, since it was
pointing to a snapshot dependency.
1219 contains:
org.apache.sling.scripting.sightly.testing, which now points to
org.apache.sling.performance.base 1.0.2.
Thanks,
Radu
On Mon, Mar 23, 2015 at 11:37 PM, Robert Munteanu <ro...@lmn.ro> wrote:
> On Mon, Mar 23, 2015 at 11:29 PM, Radu Cotescu <ra...@apache.org> wrote:
> > Hi,
> >
> > I've started a release thread for org.apache.sling.performance.base at
> > http://sling.markmail.org/thread/m7xyhb6saxfyqs6w.
> >
> > I've also dropped org.apache.sling.scripting.sightly.testing from staging
> > repository 1216 and restaged this artifact at 1219.
> >
> > You can use this UNIX script to download the release and verify the
> > signatures for org.apache.sling.scripting.sightly.testing:
> > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 1219 /tmp/sling-staging
>
> So on which repository/artifacts are we voting now? Both 1216 and 1219
> seem to be active.
>
> Robert
>
> >
> > Thanks,
> > Radu
> >
> >
> > On Mon, Mar 23, 2015 at 7:25 PM, Radu Cotescu <ra...@apache.org> wrote:
> >
> >> Hi Robert,
> >>
> >> It would be better to release that snapshot dependency in order to
> >> provide a way to easily test Sightly artifacts.
> >>
> >> I'll take care of that this evening.
> >>
> >> Cheers,
> >> Radu
> >>
> >>
> >> On Monday, March 23, 2015, Robert Munteanu <ro...@apache.org> wrote:
> >>
> >>> On Mon, 2015-03-23 at 10:50 -0400, Daniel Klco wrote:
> >>> > org.apache.sling.sightly.testing relies on a SNAPSHOT dependency:
> >>> >
> >>> > <dependency>
> >>> > <groupId>org.apache.sling</groupId>
> >>> >
> <artifactId>org.apache.sling.performance.base</artifactId>
> >>> > <version>0.0.1-SNAPSHOT</version>
> >>> > <scope>test</scope>
> >>> > </dependency>
> >>> >
> >>> > As this is a testing project, I'm not sure if this is a big deal or
> >>> > acceptable. Ideally, if we could make a release of this performance
> >>> > tools
> >>> > it would be good to apply performance tests across all of the
> >>> > scripting
> >>> > languages available in Sling.
> >>>
> >>> Good catch! I assumed the maven release plugin would be banning
> >>> SNAPSHOTs, but apparently this is not the case ...
> >>>
> >>> We can't deploy SNAPSHOT depedencies on Maven Central and we should not
> >>> as a general rule depend on SNAPSHOTs from releases, as the SNAPSHOTs
> >>> will at some point go away and make the released artifact invalid.
> >>>
> >>> So we either release the org.apache.sling.performance.base artifact and
> >>> depend on it or drop the org.apache.sling.sightly.testing artifact from
> >>> the release.
> >>>
> >>> Radu?
> >>>
> >>> Robert
> >>>
> >>>
> >>>
> >>
> >> --
> >> Sent with clumsy fingers from a touchscreen
> >>
>
>
>
> --
> Sent from my (old) computer
>
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Robert Munteanu <ro...@lmn.ro>.
On Mon, Mar 23, 2015 at 11:29 PM, Radu Cotescu <ra...@apache.org> wrote:
> Hi,
>
> I've started a release thread for org.apache.sling.performance.base at
> http://sling.markmail.org/thread/m7xyhb6saxfyqs6w.
>
> I've also dropped org.apache.sling.scripting.sightly.testing from staging
> repository 1216 and restaged this artifact at 1219.
>
> You can use this UNIX script to download the release and verify the
> signatures for org.apache.sling.scripting.sightly.testing:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1219 /tmp/sling-staging
So on which repository/artifacts are we voting now? Both 1216 and 1219
seem to be active.
Robert
>
> Thanks,
> Radu
>
>
> On Mon, Mar 23, 2015 at 7:25 PM, Radu Cotescu <ra...@apache.org> wrote:
>
>> Hi Robert,
>>
>> It would be better to release that snapshot dependency in order to
>> provide a way to easily test Sightly artifacts.
>>
>> I'll take care of that this evening.
>>
>> Cheers,
>> Radu
>>
>>
>> On Monday, March 23, 2015, Robert Munteanu <ro...@apache.org> wrote:
>>
>>> On Mon, 2015-03-23 at 10:50 -0400, Daniel Klco wrote:
>>> > org.apache.sling.sightly.testing relies on a SNAPSHOT dependency:
>>> >
>>> > <dependency>
>>> > <groupId>org.apache.sling</groupId>
>>> > <artifactId>org.apache.sling.performance.base</artifactId>
>>> > <version>0.0.1-SNAPSHOT</version>
>>> > <scope>test</scope>
>>> > </dependency>
>>> >
>>> > As this is a testing project, I'm not sure if this is a big deal or
>>> > acceptable. Ideally, if we could make a release of this performance
>>> > tools
>>> > it would be good to apply performance tests across all of the
>>> > scripting
>>> > languages available in Sling.
>>>
>>> Good catch! I assumed the maven release plugin would be banning
>>> SNAPSHOTs, but apparently this is not the case ...
>>>
>>> We can't deploy SNAPSHOT depedencies on Maven Central and we should not
>>> as a general rule depend on SNAPSHOTs from releases, as the SNAPSHOTs
>>> will at some point go away and make the released artifact invalid.
>>>
>>> So we either release the org.apache.sling.performance.base artifact and
>>> depend on it or drop the org.apache.sling.sightly.testing artifact from
>>> the release.
>>>
>>> Radu?
>>>
>>> Robert
>>>
>>>
>>>
>>
>> --
>> Sent with clumsy fingers from a touchscreen
>>
--
Sent from my (old) computer
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Radu Cotescu <ra...@apache.org>.
Hi,
I've started a release thread for org.apache.sling.performance.base at
http://sling.markmail.org/thread/m7xyhb6saxfyqs6w.
I've also dropped org.apache.sling.scripting.sightly.testing from staging
repository 1216 and restaged this artifact at 1219.
You can use this UNIX script to download the release and verify the
signatures for org.apache.sling.scripting.sightly.testing:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh 1219 /tmp/sling-staging
Thanks,
Radu
On Mon, Mar 23, 2015 at 7:25 PM, Radu Cotescu <ra...@apache.org> wrote:
> Hi Robert,
>
> It would be better to release that snapshot dependency in order to
> provide a way to easily test Sightly artifacts.
>
> I'll take care of that this evening.
>
> Cheers,
> Radu
>
>
> On Monday, March 23, 2015, Robert Munteanu <ro...@apache.org> wrote:
>
>> On Mon, 2015-03-23 at 10:50 -0400, Daniel Klco wrote:
>> > org.apache.sling.sightly.testing relies on a SNAPSHOT dependency:
>> >
>> > <dependency>
>> > <groupId>org.apache.sling</groupId>
>> > <artifactId>org.apache.sling.performance.base</artifactId>
>> > <version>0.0.1-SNAPSHOT</version>
>> > <scope>test</scope>
>> > </dependency>
>> >
>> > As this is a testing project, I'm not sure if this is a big deal or
>> > acceptable. Ideally, if we could make a release of this performance
>> > tools
>> > it would be good to apply performance tests across all of the
>> > scripting
>> > languages available in Sling.
>>
>> Good catch! I assumed the maven release plugin would be banning
>> SNAPSHOTs, but apparently this is not the case ...
>>
>> We can't deploy SNAPSHOT depedencies on Maven Central and we should not
>> as a general rule depend on SNAPSHOTs from releases, as the SNAPSHOTs
>> will at some point go away and make the released artifact invalid.
>>
>> So we either release the org.apache.sling.performance.base artifact and
>> depend on it or drop the org.apache.sling.sightly.testing artifact from
>> the release.
>>
>> Radu?
>>
>> Robert
>>
>>
>>
>
> --
> Sent with clumsy fingers from a touchscreen
>
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Radu Cotescu <ra...@apache.org>.
Hi Robert,
It would be better to release that snapshot dependency in order to provide
a way to easily test Sightly artifacts.
I'll take care of that this evening.
Cheers,
Radu
On Monday, March 23, 2015, Robert Munteanu <ro...@apache.org> wrote:
> On Mon, 2015-03-23 at 10:50 -0400, Daniel Klco wrote:
> > org.apache.sling.sightly.testing relies on a SNAPSHOT dependency:
> >
> > <dependency>
> > <groupId>org.apache.sling</groupId>
> > <artifactId>org.apache.sling.performance.base</artifactId>
> > <version>0.0.1-SNAPSHOT</version>
> > <scope>test</scope>
> > </dependency>
> >
> > As this is a testing project, I'm not sure if this is a big deal or
> > acceptable. Ideally, if we could make a release of this performance
> > tools
> > it would be good to apply performance tests across all of the
> > scripting
> > languages available in Sling.
>
> Good catch! I assumed the maven release plugin would be banning
> SNAPSHOTs, but apparently this is not the case ...
>
> We can't deploy SNAPSHOT depedencies on Maven Central and we should not
> as a general rule depend on SNAPSHOTs from releases, as the SNAPSHOTs
> will at some point go away and make the released artifact invalid.
>
> So we either release the org.apache.sling.performance.base artifact and
> depend on it or drop the org.apache.sling.sightly.testing artifact from
> the release.
>
> Radu?
>
> Robert
>
>
>
--
Sent with clumsy fingers from a touchscreen
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2015-03-23 at 10:50 -0400, Daniel Klco wrote:
> org.apache.sling.sightly.testing relies on a SNAPSHOT dependency:
>
> <dependency>
> <groupId>org.apache.sling</groupId>
> <artifactId>org.apache.sling.performance.base</artifactId>
> <version>0.0.1-SNAPSHOT</version>
> <scope>test</scope>
> </dependency>
>
> As this is a testing project, I'm not sure if this is a big deal or
> acceptable. Ideally, if we could make a release of this performance
> tools
> it would be good to apply performance tests across all of the
> scripting
> languages available in Sling.
Good catch! I assumed the maven release plugin would be banning
SNAPSHOTs, but apparently this is not the case ...
We can't deploy SNAPSHOT depedencies on Maven Central and we should not
as a general rule depend on SNAPSHOTs from releases, as the SNAPSHOTs
will at some point go away and make the released artifact invalid.
So we either release the org.apache.sling.performance.base artifact and
depend on it or drop the org.apache.sling.sightly.testing artifact from
the release.
Radu?
Robert
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Daniel Klco <dk...@apache.org>.
org.apache.sling.sightly.testing relies on a SNAPSHOT dependency:
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.performance.base</artifactId>
<version>0.0.1-SNAPSHOT</version>
<scope>test</scope>
</dependency>
As this is a testing project, I'm not sure if this is a big deal or
acceptable. Ideally, if we could make a release of this performance tools
it would be good to apply performance tests across all of the scripting
languages available in Sling.
-Dan
On Mon, Mar 23, 2015 at 10:43 AM, Robert Munteanu <ro...@apache.org>
wrote:
> On Mon, 2015-03-23 at 12:03 +0200, Radu Cotescu wrote:
> > Please vote to approve this release:
> >
> > [ ] +1 Approve the release
>
> +1
>
> Robert
>
>
Re: [VOTE] Release Apache Sling Scripting Sightly 1.0.0
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2015-03-23 at 12:03 +0200, Radu Cotescu wrote:
> Please vote to approve this release:
>
> [ ] +1 Approve the release
+1
Robert