You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/04 05:57:19 UTC

[GitHub] [pulsar] michaeljmarshall commented on pull request #10254: [Broker] Remove possible error case for system topic name checking

michaeljmarshall commented on pull request #10254:
URL: https://github.com/apache/pulsar/pull/10254#issuecomment-831700209


   @sijie and @congbobo184 - I just added a commit addressing the comments. However, I am wondering if this is the right change. While rebasing, I noticed that #10334 shows that there are possibly more system topics than I realized. When initially writing the PR, I had assumed that the `EventsTopicNames` class contained all system topics, however, that might not be true. Let me know if this PR needs more changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org