You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/20 08:59:25 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9624: [Bug] cancel application when kill task

caishunfeng commented on code in PR #9624:
URL: https://github.com/apache/dolphinscheduler/pull/9624#discussion_r853897840


##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskKillProcessor.java:
##########
@@ -146,27 +136,48 @@ private Pair<Boolean, List<String>> doKill(TaskExecutionContext taskExecutionCon
     }
 
     /**
-     * build TaskKillResponseCommand
-     *
-     * @param killCommand kill command
-     * @param result exe result
-     * @return build TaskKillResponseCommand
+     * kill task by cancel application
+     * @param taskInstanceId
      */
-    private TaskKillResponseCommand buildKillTaskResponseCommand(TaskKillRequestCommand killCommand,

Review Comment:
   remove unuse function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org