[GitHub] [tvm] csullivan commented on a change in pull request #9138: [LLVM] Make changes needed for opaque pointers

[GitBox <gi...@apache.org>]

csullivan commented on a change in pull request #9138:
URL: https://github.com/apache/tvm/pull/9138#discussion_r721761938



##########
File path: src/target/llvm/codegen_llvm.cc
##########
@@ -861,10 +871,10 @@ llvm::Value* CodeGenLLVM::CreateIntrinsic(const CallNode* op) {
                                                                 : llvm::Type::getVoidTy(*ctx_);
     llvm::Function* f = GetIntrinsicDecl(id, return_type, arg_type);
     ICHECK(f) << "Cannot find intrinsic declaration, possible type mismatch: "
-#if TVM_LLVM_VERSION <= 130
-              << llvm::Intrinsic::getName(id, {});
+#if TVM_LLVM_VERSION >= 130
+              << llvm::Intrinsic::getBaseName(id).str();
 #else
-              << llvm::Intrinsic::getName(id, return_type, {});
+              << llvm::Intrinsic::getName(id, {});

Review comment:
       >release/181/llvm-10.0.0/bin/llvm-config --version
   13.0.0
   
   Using a copy of the hexagon llvm libraries from early this summer (rev 181) this now triggers a compile error. Did you mean `>` instead of `>=` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org