[jira] [Commented] (FLINK-6696) Test checkstyle is also applied to .properties files under /src/test/resources

["Greg Hogan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022773#comment-16022773 ] 

Greg Hogan commented on FLINK-6696:
-----------------------------------

Text files should end with a new line for consistency and so that, for example, when cat'ing a file the prompt is not appended to the last line of the file. There may be conflicts between the configured checkstyle and test resources but I don't think we should exclude the test resources until such time.

> Test checkstyle is also applied to .properties files under /src/test/resources
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-6696
>                 URL: https://issues.apache.org/jira/browse/FLINK-6696
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.4.0
>
>
> While working on FLINK-6695 I stumbled upon this curious checkstyle error in the flink-storm:
> {code}
> [ERROR] src\test\resources\log4j-test.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline.
> {code}
> I don't think we meant to include the resources directory. [~greghogan]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)