You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/03/26 12:20:52 UTC
[PR] protect 1.0.x branch and enable scala 2 inlining in main [pekko-connectors-kafka]
pjfanning opened a new pull request, #149:
URL: https://github.com/apache/pekko-connectors-kafka/pull/149
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch and enable scala 2 inlining in main [pekko-connectors-kafka]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #149:
URL: https://github.com/apache/pekko-connectors-kafka/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch and enable scala 2 inlining in main [pekko-connectors-kafka]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #149:
URL: https://github.com/apache/pekko-connectors-kafka/pull/149#discussion_r1539196991
##########
build.sbt:
##########
@@ -14,7 +14,6 @@ import ProjectSettings.commonSettings
sourceDistName := "apache-pekko-connectors-kafka"
sourceDistIncubating := false
-ThisBuild / pekkoInlineEnabled := false
Review Comment:
@mdedetrich is the one driving this inlining. We have it enabled on all pekko 1.1 modules. I'm just keeping this module consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch and enable scala 2 inlining in main [pekko-connectors-kafka]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #149:
URL: https://github.com/apache/pekko-connectors-kafka/pull/149#discussion_r1540592632
##########
build.sbt:
##########
@@ -14,7 +14,6 @@ import ProjectSettings.commonSettings
sourceDistName := "apache-pekko-connectors-kafka"
sourceDistIncubating := false
-ThisBuild / pekkoInlineEnabled := false
Review Comment:
> Do I understand correctly that enabling inlining is safe while we're still targeting pekko 1.0.x, but we'll start seeing benefits once we're targeting pekko 1.1.x?
Yes this is correct.
Also one of the reasons behind dong an `-M1` release for the variou modules is because of enablement of inlining. While its considered safe, it does do things like modify the stack and there might be some implications for code that relies on that (i.e. in a couple of cases I had to use `@noinline` because there was code that was inspecting stack, this occurred in testkit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch and enable scala 2 inlining in main [pekko-connectors-kafka]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #149:
URL: https://github.com/apache/pekko-connectors-kafka/pull/149#discussion_r1539128527
##########
build.sbt:
##########
@@ -14,7 +14,6 @@ import ProjectSettings.commonSettings
sourceDistName := "apache-pekko-connectors-kafka"
sourceDistIncubating := false
-ThisBuild / pekkoInlineEnabled := false
Review Comment:
Do I understand correctly that enabling inlining is safe while we're still targeting pekko 1.0.x, but we'll start seeing benefits once we're targeting pekko 1.1.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org