You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/05/06 01:28:05 UTC
[GitHub] [drill] paul-rogers opened a new pull request #2077: DRILL-7734: Revise the result set reader
paul-rogers opened a new pull request #2077:
URL: https://github.com/apache/drill/pull/2077
# [DRILL-7734](https://issues.apache.org/jira/browse/DRILL-7734): Revise the result set reader
## Description
The "result set reader" uses the column accessors to iterate over rows from multiple batches, similar to how the "result set loader" creates batches in a scan. This PR refactors the code to clarify the two ways that the reader is used. First, the "pull" reader in one operator reads ("pulls") batches from an upstream operator. To implement JSON streaming, we need a second model, a "push" version where a caller provides batches.
## Documentation
N/A
## Testing
Added tests. Reran all unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] paul-rogers commented on pull request #2077: DRILL-7734: Revise the result set reader
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on pull request #2077:
URL: https://github.com/apache/drill/pull/2077#issuecomment-633395199
@vvysotskyi thanks for the review! Addressed checkstyle issue. Rebased on latest master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] asfgit closed pull request #2077: DRILL-7734: Revise the result set reader
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2077:
URL: https://github.com/apache/drill/pull/2077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2077: DRILL-7734: Revise the result set reader
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on pull request #2077:
URL: https://github.com/apache/drill/pull/2077#issuecomment-633135657
@paul-rogers, changes look good. Could you please resolve the checkstyle failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org