You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2023/03/15 15:49:10 UTC
[GitHub] [shardingsphere] yx9o opened a new pull request, #24632: Add final and modify the return variable to result
yx9o opened a new pull request, #24632:
URL: https://github.com/apache/shardingsphere/pull/24632
Add final and modify the return variable to result.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24632: Add final and modify the return variable to result
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24632:
URL: https://github.com/apache/shardingsphere/pull/24632#issuecomment-1471207117
## [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24632](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a27c46d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/13560a79b4a9afbcef1a771f04e11d023e8bc16a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13560a7) will **increase** coverage by `0.03%`.
> The diff coverage is `60.37%`.
> :exclamation: Current head a27c46d differs from pull request most recent head 0506fb4. Consider uploading reports for the commit 0506fb4 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24632 +/- ##
============================================
+ Coverage 50.00% 50.03% +0.03%
+ Complexity 1597 1593 -4
============================================
Files 3336 3329 -7
Lines 54564 54416 -148
Branches 8075 8040 -35
============================================
- Hits 27282 27226 -56
+ Misses 24821 24736 -85
+ Partials 2461 2454 -7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9TaGFyZGluZ1J1bGUuamF2YQ==) | `84.19% <ø> (-0.06%)` | :arrow_down: |
| [...pipeline/cdc/client/handler/CDCRequestHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jZGMvY2xpZW50L2hhbmRsZXIvQ0RDUmVxdWVzdEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ine/cdc/client/util/ProtobufAnyValueConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jZGMvY2xpZW50L3V0aWwvUHJvdG9idWZBbnlWYWx1ZUNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dc/core/connector/SocketSinkImporterConnector.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvY29ubmVjdG9yL1NvY2tldFNpbmtJbXBvcnRlckNvbm5lY3Rvci5qYXZh) | `15.55% <0.00%> (ø)` | |
| [...e/proxy/backend/handler/cdc/CDCBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2hhbmRsZXIvY2RjL0NEQ0JhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...shardingsphere/proxy/backend/util/ExportUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL3V0aWwvRXhwb3J0VXRpbHMuamF2YQ==) | `50.90% <ø> (ø)` | |
| [...proxy/frontend/netty/CDCChannelInboundHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvbmV0dHkvQ0RDQ2hhbm5lbEluYm91bmRIYW5kbGVyLmphdmE=) | `25.20% <0.00%> (ø)` | |
| [...data/pipeline/cdc/util/ColumnValueConvertUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL3V0aWwvQ29sdW1uVmFsdWVDb252ZXJ0VXRpbC5qYXZh) | `76.38% <72.72%> (-1.20%)` | :arrow_down: |
| [...olumn/value/time/MySQLDateBinlogProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS90aW1lL015U1FMRGF0ZUJpbmxvZ1Byb3RvY29sVmFsdWUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...pipeline/cdc/util/DataRecordResultConvertUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL3V0aWwvRGF0YVJlY29yZFJlc3VsdENvbnZlcnRVdGlsLmphdmE=) | `62.50% <100.00%> (-7.50%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/shardingsphere/pull/24632?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [2 files with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere/pull/24632/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24632: Add final and modify the return variable to result
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24632:
URL: https://github.com/apache/shardingsphere/pull/24632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org