[jira] [Resolved] (FLINK-13965) Keep hasDeprecatedKeys and deprecatedKeys methods in ConfigOption and mark it with @Deprecated annotation

["Till Rohrmann (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Rohrmann resolved FLINK-13965.
-----------------------------------
    Resolution: Done

Done via

1.10.0: 64b656b705864ed88d8ca0c4794f4a9bba7faabb
1.9.1: 2a22b1c037ba259b9c3bd4f35fa8d06f531f6854
1.8.3: 517bd293600d787b47175ce4e46be8746f15af97

> Keep hasDeprecatedKeys and deprecatedKeys methods in ConfigOption and mark it with @Deprecated annotation
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-13965
>                 URL: https://issues.apache.org/jira/browse/FLINK-13965
>             Project: Flink
>          Issue Type: Test
>    Affects Versions: 1.9.0
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0, 1.9.1, 1.8.3
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In our program based on Flink 1.7.2, we used method {{ConfigOption#hasDeprecatedKeys}}. But, this method was renamed to {{hasFallbackKeys}} in FLINK-10436. So after we bump our flink version to 1.9.0, we meet compile error.
>  
> It seems we replaced the deprecated key with an entity {{FallbackKey}}. However, I still see the method {{withDeprecatedKeys}}. Since we keep the method {{withDeprecatedKeys}}, why not keep the method {{hasDeprecatedKeys}}. Although, this public API did not marked as {{Public}} annotation. IMHO, {{ConfigOption}} is hosted in flink-core module, many users also use it, we should maintain the compatibility as far as possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)