You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/22 09:05:23 UTC

[GitHub] [airflow] ciancolo opened a new issue #17158: Breeze build image behind proxy

ciancolo opened a new issue #17158:
URL: https://github.com/apache/airflow/issues/17158


   Hello all, 
   
   **Description**
   Add to Breeze commands `build-image` and `build-docs` (needs also in other commands?) a parameter (or more) to specify proxy configurations for the image and docs build.
   
   **Use case / motivation**
   Recently I started to contribute to Airflow project, but I had some problems creating and configure the development environment with Breeze. My workstation is behind my company proxy and this creates a problem in the download of the necessary Python packages and the GPG public key during the image build. My workstation is already configured to work with proxy (I configured apt, docker...) but in this case, it didn't work.
   
   I have a similar problem with `./breeze build-docs` command.
   
   **Are you willing to submit a PR?**
   
   I'm not an expert in Breeze or bash script. Applying these 2 changes was enough to be able to build the image with Breeze:
   
   1.  scripts/ci/libraries/_build_images.sh
   ![image](https://user-images.githubusercontent.com/18025873/126613660-72fc8184-a3c3-4251-9805-eeaa26bf74cc.png)
   
   2. scripts/docker/install_mysql.sh
   ![image](https://user-images.githubusercontent.com/18025873/126613673-f17ad2ee-5049-4bcd-83e9-c8a78f87c9f3.png)
   
   But of course, it will be better to use some global parameters, and I don't know if there are other cases where it is important to set proxy configuration.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ciancolo commented on issue #17158: Breeze build image or docs behind proxy

Posted by GitBox <gi...@apache.org>.
ciancolo commented on issue #17158:
URL: https://github.com/apache/airflow/issues/17158#issuecomment-892493152


   Hi @potiuk,
   It is still a WIP change. I prepared the parameters to set proxy configuration for image build and that seems to work fine, but it is necessary to set the proxy also in case run Airflow with Breeze local env: it is necessary for the installation of all the needed packages for webpage build.
   
   Currently, I'm in vacation with no access to my dev env. I'm going to complete the work when I will back to work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #17158: Breeze build image behind proxy

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17158:
URL: https://github.com/apache/airflow/issues/17158#issuecomment-884761370


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #17158: Breeze build image or docs behind proxy

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17158:
URL: https://github.com/apache/airflow/issues/17158#issuecomment-890583255


   Hey @ciancolo - how about the change here :) ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #17158: Breeze build image or docs behind proxy

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17158:
URL: https://github.com/apache/airflow/issues/17158#issuecomment-884770075


   Thanks! Very interesting and useful I think.  
   
   I think the way you described id is exactly how it should be done. Would you like to contribute a PR with those changes? In order to make it more "complete" the parameters should follow the convention  AIRFLOW_HTTP_PROXY, AIRFLOW_HTTPS_PROXY  and update the documentation in IMAGES.rst and maybe a few other places where build-args are mentioned (also in the instructions in `docs/docker-stack'. 
   
   I'd love if you contribute that change @ciancolo ? Would you :D ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #17158: Breeze build image or docs behind proxy

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17158:
URL: https://github.com/apache/airflow/issues/17158#issuecomment-886690207


   > I will try to propose a PR.
   > Do you know if there are tests for development env configurations
   
   Most of the scripts in dev env are used in CI to run tests so pretty much all of them are tested in every single PR, same with Docker  - it is build in a number of combinations and even automatically tested during the CI builds, so whenever you PR gets "green" you should not worry about regressions. About 90% of the dev scripts are also used for CI I'd estimate. And those that are not tested are mostly the ones that are very much "user-facing"
   
   When it come to testing with proxy, we have no environment prepared to test it with a proxy, unless you want to set it up in our CI, but I think it's a bit too much hassle and it's a bit too "niche" to setup a CI for it, So I'd say review + manual testing should suffice. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org