You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by cg...@apache.org on 2022/05/23 13:10:41 UTC
[drill] branch master updated: [MINOR UPDATE] Disable TestJdbcPluginWithMSSQL when not on amd64. (#2557)
This is an automated email from the ASF dual-hosted git repository.
cgivre pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/drill.git
The following commit(s) were added to refs/heads/master by this push:
new 5085877bf8 [MINOR UPDATE] Disable TestJdbcPluginWithMSSQL when not on amd64. (#2557)
5085877bf8 is described below
commit 5085877bf8d1166b6829041863bfc00dcf2f03ba
Author: James Turton <91...@users.noreply.github.com>
AuthorDate: Mon May 23 15:10:35 2022 +0200
[MINOR UPDATE] Disable TestJdbcPluginWithMSSQL when not on amd64. (#2557)
* [MINOR UPDATE] Disable TestJdbcPluginWithMSSQL when not on amd64.
* Try using DisabledIf... instead of EnabledIf.. at class level.
* Try adding EnabledIf... annotation to static setup and teardown methods.
* Try adding a manual bypass to the @BeforeClass method.
* Try using method-level EnabledIf... annotations.
* Try to disable using os.arch = "aarch_64".
* Try using org.junit.Assume instead of annotations.
---
.../org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java b/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
index 68c6871261..c759dfe978 100644
--- a/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
+++ b/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
@@ -30,6 +30,7 @@ import org.apache.drill.test.ClusterFixture;
import org.apache.drill.test.ClusterTest;
import org.apache.drill.test.rowSet.RowSetUtilities;
import org.junit.AfterClass;
+import org.junit.Assume;
import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test;
@@ -43,7 +44,8 @@ import java.util.Map;
import static org.junit.Assert.assertEquals;
/**
- * JDBC storage plugin tests against MSSQL.
+ * JDBC storage plugin tests against MSSQL. Note that there is no mssql container
+ * available on aarch64 so these tests must be disabled on that arch.
*/
@Category(JdbcStorageTest.class)
public class TestJdbcPluginWithMSSQL extends ClusterTest {
@@ -52,6 +54,8 @@ public class TestJdbcPluginWithMSSQL extends ClusterTest {
@BeforeClass
public static void initMSSQL() throws Exception {
+ Assume.assumeTrue(System.getProperty("os.arch").matches("(amd64|x86_64)"));
+
startCluster(ClusterFixture.builder(dirTestWatcher));
TimeZone.setDefault(TimeZone.getTimeZone("UTC"));