You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/13 19:41:53 UTC
[GitHub] [beam] ibzib opened a new pull request #11696: [BEAM-9975] Log invalid dictionary after unsuccessful struct conversion.
ibzib opened a new pull request #11696:
URL: https://github.com/apache/beam/pull/11696
I'm also working on improving the error message upstream, but that will take some time to percolate up to Beam.
R: @aaltay
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #11696: [BEAM-9975] Log invalid dictionary after unsuccessful struct conversion.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #11696:
URL: https://github.com/apache/beam/pull/11696#discussion_r424764668
##########
File path: sdks/python/apache_beam/runners/job/utils.py
##########
@@ -23,14 +23,19 @@
from __future__ import absolute_import
import json
+import logging
from google.protobuf import json_format
from google.protobuf import struct_pb2
def dict_to_struct(dict_obj):
# type: (dict) -> struct_pb2.Struct
- return json_format.ParseDict(dict_obj, struct_pb2.Struct())
+ try:
+ return json_format.ParseDict(dict_obj, struct_pb2.Struct())
+ except json_format.ParseError:
+ logging.error('Failed to parse dict {0}'.format(dict_obj))
Review comment:
Managed to apply the change myself in the UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11696: [BEAM-9975] Log invalid dictionary after unsuccessful struct conversion.
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11696:
URL: https://github.com/apache/beam/pull/11696#discussion_r424767747
##########
File path: sdks/python/apache_beam/runners/job/utils.py
##########
@@ -23,14 +23,19 @@
from __future__ import absolute_import
import json
+import logging
from google.protobuf import json_format
from google.protobuf import struct_pb2
def dict_to_struct(dict_obj):
# type: (dict) -> struct_pb2.Struct
- return json_format.ParseDict(dict_obj, struct_pb2.Struct())
+ try:
+ return json_format.ParseDict(dict_obj, struct_pb2.Struct())
+ except json_format.ParseError:
+ logging.error('Failed to parse dict {0}'.format(dict_obj))
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #11696: [BEAM-9975] Log invalid dictionary after unsuccessful struct conversion.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #11696:
URL: https://github.com/apache/beam/pull/11696#discussion_r424762163
##########
File path: sdks/python/apache_beam/runners/job/utils.py
##########
@@ -23,14 +23,19 @@
from __future__ import absolute_import
import json
+import logging
from google.protobuf import json_format
from google.protobuf import struct_pb2
def dict_to_struct(dict_obj):
# type: (dict) -> struct_pb2.Struct
- return json_format.ParseDict(dict_obj, struct_pb2.Struct())
+ try:
+ return json_format.ParseDict(dict_obj, struct_pb2.Struct())
+ except json_format.ParseError:
+ logging.error('Failed to parse dict {0}'.format(dict_obj))
Review comment:
lint error:
```
apache_beam/runners/job/utils.py:37:18: W1202: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib merged pull request #11696: [BEAM-9975] Log invalid dictionary after unsuccessful struct conversion.
Posted by GitBox <gi...@apache.org>.
ibzib merged pull request #11696:
URL: https://github.com/apache/beam/pull/11696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org