[GitHub] [spark] srowen commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines

[GitBox <gi...@apache.org>]

srowen commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#issuecomment-597077280
 
 
   I think the two remaining issues are:
   - Should this threshold be configurable, only within `mllib` at least?
   - Should the default / hard-coded value be larger, to be 'safer'?
   
   Possibly still partly configurable, yes; I don't feel strongly about it.
   @mengxr 's last question was, how does this compare on older hardware, like Ivy Bridge or similar, maybe? I think we're aiming for a value that should not cause a slowdown on hardware people might be realistically running now, especially if they haven't tuned BLAS threads. That number might be higher than 256 and I expect it is, but just guessing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org