[GitHub] maskit commented on a change in pull request #2888: PIP-25: Token based authentication

[GitBox <gi...@apache.org>]

maskit commented on a change in pull request #2888: PIP-25: Token based authentication
URL: https://github.com/apache/pulsar/pull/2888#discussion_r233478815
 
 

 ##########
 File path: conf/broker.conf
 ##########
 @@ -274,6 +274,24 @@ athenzDomainNames=
 # When this parameter is not empty, unauthenticated users perform as anonymousUserRole
 anonymousUserRole=
 
+### --- Token Authentication Provider --- ###
+
+## Simmetric key
+# Configure the secret key directly in this config file
+tokenSecretKey=
+# Read secret key from an environment variable
+tokenSecretKeyFromEnv=
+# Read secret key from a file
+tokenSecretKeyFromFile=
 
 Review comment:
   Are there any case that we want to read tokenSecretKey from both Env and File?
   How about using URL scheme?
   ```
   tokenSecretKey=env:///FOO_BAR
   tokenSecretKey=file:///path/for/file
   ```
   
   Once we added support for "env:///" (not sure if we need 3 slashes) to `org.apache.pulsar.client.api.url.URL`, every places that use the class would support reading configuration from environment variable.
   
   Reference: #672, #1212

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services