You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sanjaydasgupta <gi...@git.apache.org> on 2018/06/18 07:27:58 UTC
[GitHub] zeppelin pull request #3027: [ZEPPELIN-2605] Import notebook has 1MB size li...
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/3027
[ZEPPELIN-2605] Import notebook has 1MB size limit but bigger notebooks can be saved without error or warning
### What is this PR for?
Notebooks of any size can be exported and saved, but the import facility only accepts notebooks up to 1Mb in size. Allowing notebooks bigger than 1Mb to be saved silently (without any warning or error notification) is therefore a dangerous trap for users.
It has been argued that notebooks bigger than 1Mb are rare and unusual, but a saved notebook also contains the displayed output - and can contain large volumes of tabular data, and even images from matplotlib output. Large notebooks can be common when zeppelin is used for presentation of visual analysis.
This PR adds a popup dialog which is displayed when the user attempts to export a notebook that has a size exceeding 1Mb. A screenshot of the popup is shown below.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2605
### How should this be tested?
CI pass
Manual testing. A notebook that is small when outputs are cleared, but becomes bigger than the limit when all cells are run is included (big-output-tester.json).
[big-output-tester.json.zip](https://github.com/apache/zeppelin/files/2110281/big-output-tester.json.zip)
### Screenshots (if appropriate)
See above.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjaydasgupta/zeppelin z2605-import-notebook-has-1mb-limit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3027.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3027
----
commit 943eb5df21a5563ccc588164d0799724e7dd3260
Author: Sanjay Dasgupta <sa...@...>
Date: 2018-06-17T17:17:38Z
z2605-import-notebook-has-1mb-limit: Initial content
----
---
[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3027
Thanks @sanjaydasgupta . LGTM
---
[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3027
@sanjaydasgupta thank you!
LGTM
---
[GitHub] zeppelin pull request #3027: [ZEPPELIN-2605] Import notebook has 1MB size li...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3027
---
[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...
Posted by sanjaydasgupta <gi...@git.apache.org>.
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3027
Hi Jeff,
The window is popped up only when the user tries to export a notebook that
would be more than 1Mb in size.
The problem with such a notebook (greater than 1Mb in size) is that it is
not allowed to be imported again. So allowing such a big notebook to be
exported without any warning is a bug.
Regards,
- Sanjay
On Tue, Jun 26, 2018 at 8:13 AM, Jeff Zhang <no...@github.com>
wrote:
> But what is the meaning of this pop up window ? As a user, it's not clear
> to me what is the impact if I import this kind of notebook
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zeppelin/pull/3027#issuecomment-400159608>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAdHV5i8OR1842LaRudDiUrCC3tw0yy4ks5uAZ-8gaJpZM4UrRQD>
> .
>
---
[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3027
But what is the meaning of this pop up window ? As a user, it's not clear to me what is the impact if I import this kind of notebook
---
[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...
Posted by sanjaydasgupta <gi...@git.apache.org>.
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3027
ping @jongyoul
---