[PR] [ISSUE #10877] Fix Boolean-to-string filter comparison [rocketmq]

["btlqql (via GitHub)" <gi...@apache.org>]

btlqql opened a new pull request, #10922:
URL: https://github.com/apache/rocketmq/pull/10922

   ## What is the purpose of the change
   
   Fix #10877.
   
   ComparisonExpression handled a Boolean left operand and String right operand by casting the Boolean left value to String. With string-expression conversion enabled by the selector parser, this branch always threw ClassCastException because a Boolean cannot be cast to String.
   
   ## Brief changelog
   
   - ComparisonExpression.__compare: for a Boolean left operand against a String right operand, convert the right operand with Boolean.valueOf instead of casting the left Boolean to String
   
   ## How was this patch verified
   
   - Code review: mirrors the symmetric String-left / Boolean-right branch which uses Boolean.valueOf on the String operand
   - `git diff --check` clean
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #10877] Fix Boolean-to-string filter comparison [rocketmq]

["RockteMQ-AI (via GitHub)" <gi...@apache.org>]

RockteMQ-AI commented on PR #10922:
URL: https://github.com/apache/rocketmq/pull/10922#issuecomment-5276400037

   ⚠️ **Merge conflict detected**
   
   This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
   
   ```bash
   git fetch origin
   git checkout btlqql/fix-boolean-string-filter
   git rebase origin/develop
   # resolve conflicts, then:
   git push --force-with-lease
   ```
   
   This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
   
   ---
   *Automated notification by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org