[GitHub] [avro] thiru-mg commented on a change in pull request #954: AVRO-2891: Expose last sync offset written on DataFileWriter

[GitBox <gi...@apache.org>]

thiru-mg commented on a change in pull request #954:
URL: https://github.com/apache/avro/pull/954#discussion_r496440539



##########
File path: lang/c++/api/DataFile.hh
##########
@@ -102,6 +103,11 @@ public:
      */
     void syncIfNeeded();
 
+    /**
+     * Returns offset to the last sync marker written.
+     */
+    uint64_t getLastSync();

Review comment:
       I think the name is bit ambiguous, it could mean either the beginning of the sync marker or the end of the sync marker. I think `currentBlockStart()` or something like it. The comment could read:
   
        Returns the byte offset (within the current file) of the start of the current block being written.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org