You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/11/17 04:17:47 UTC
[GitHub] [iotdb] haimeiguo opened a new pull request #2060: division by zero bug
haimeiguo opened a new pull request #2060:
URL: https://github.com/apache/iotdb/pull/2060
division by zero bug, when endtime - starttime < interval
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] haimeiguo commented on a change in pull request #2060: division by zero bug
Posted by GitBox <gi...@apache.org>.
haimeiguo commented on a change in pull request #2060:
URL: https://github.com/apache/iotdb/pull/2060#discussion_r524909297
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.java
##########
@@ -687,8 +687,10 @@ private void deduplicate(QueryPlan queryPlan, int fetchSize)
if (queryPlan instanceof GroupByTimePlan) {
GroupByTimePlan plan = (GroupByTimePlan) queryPlan;
// the actual row number of group by query should be calculated from startTime, endTime and interval.
- fetchSize = Math
- .min((int) ((plan.getEndTime() - plan.getStartTime()) / plan.getInterval()), fetchSize);
+ long interval = (plan.getEndTime() - plan.getStartTime()) / plan.getInterval();
Review comment:
yes. if you set interval = 0, it will throw exception: "Interval must more than 0"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow merged pull request #2060: division by zero bug
Posted by GitBox <gi...@apache.org>.
mychaow merged pull request #2060:
URL: https://github.com/apache/iotdb/pull/2060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2060: division by zero bug
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2060:
URL: https://github.com/apache/iotdb/pull/2060#issuecomment-728678373
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i
ssues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2060&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2060) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2060&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2060&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on a change in pull request #2060: division by zero bug
Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #2060:
URL: https://github.com/apache/iotdb/pull/2060#discussion_r524875355
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.java
##########
@@ -687,8 +687,10 @@ private void deduplicate(QueryPlan queryPlan, int fetchSize)
if (queryPlan instanceof GroupByTimePlan) {
GroupByTimePlan plan = (GroupByTimePlan) queryPlan;
// the actual row number of group by query should be calculated from startTime, endTime and interval.
- fetchSize = Math
- .min((int) ((plan.getEndTime() - plan.getStartTime()) / plan.getInterval()), fetchSize);
+ long interval = (plan.getEndTime() - plan.getStartTime()) / plan.getInterval();
Review comment:
What about the plan.getInterval() is zero? does the code has been checked before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on a change in pull request #2060: division by zero bug
Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #2060:
URL: https://github.com/apache/iotdb/pull/2060#discussion_r524914398
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.java
##########
@@ -687,8 +687,10 @@ private void deduplicate(QueryPlan queryPlan, int fetchSize)
if (queryPlan instanceof GroupByTimePlan) {
GroupByTimePlan plan = (GroupByTimePlan) queryPlan;
// the actual row number of group by query should be calculated from startTime, endTime and interval.
- fetchSize = Math
- .min((int) ((plan.getEndTime() - plan.getStartTime()) / plan.getInterval()), fetchSize);
+ long interval = (plan.getEndTime() - plan.getStartTime()) / plan.getInterval();
Review comment:
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org