[ignite-teamcity-bot] branch master updated: IGNITE-10336 Running build can cause bot to think there are no failures

[dp...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dpavlov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite-teamcity-bot.git


The following commit(s) were added to refs/heads/master by this push:
     new 58dabd1  IGNITE-10336 Running build can cause bot to think there are no failures
58dabd1 is described below

commit 58dabd17bc5935b119acced4a0d8c177f5a7e99b
Author: Dmitriy Pavlov <dp...@apache.org>
AuthorDate: Mon Nov 19 21:36:41 2018 +0300

    IGNITE-10336 Running build can cause bot to think there are no failures
---
 .../java/org/apache/ignite/ci/tcbot/chain/BuildChainProcessor.java     | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/chain/BuildChainProcessor.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/chain/BuildChainProcessor.java
index 93915b3..e929bb8 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/chain/BuildChainProcessor.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/chain/BuildChainProcessor.java
@@ -296,7 +296,6 @@ public class BuildChainProcessor {
                     .orElse(buildCompacted);
 
             return Stream.of(recentRef)
-                .filter(b -> !builds.containsKey(b.id()))
                 .map(b -> builds.computeIfAbsent(b.id(), id -> teamcityIgnited.getFatBuild(id, syncMode)));
         }
 
@@ -304,7 +303,7 @@ public class BuildChainProcessor {
             return hist
                 .sorted(Comparator.comparing(BuildRefCompacted::id).reversed())
                 .limit(cntLimit)
-                .filter(b -> !builds.containsKey(b.id()))
+                .filter(b -> !builds.containsKey(b.id())) // todo removing this causes incorrect count of failures (duplicated builds)
                 .map(b -> builds.computeIfAbsent(b.id(), id -> teamcityIgnited.getFatBuild(id, syncMode)));
         }