You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by jingyimei <gi...@git.apache.org> on 2018/05/25 21:11:08 UTC
[GitHub] madlib pull request #273: Minibatch Preprocessing: fix dependent var with sp...
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/273
Minibatch Preprocessing: fix dependent var with special character
JIRA:MADLIB-1237
Previously, minibatch processing would error out when the specified
dependent variable has special characters within its values. We
fixed this in two places:
1. in the query with WHERE condition, we use $$ to queto string instead
of ' ' to do string equals.
2. in the query with creating an array column, instead of using
SELECT '{ele'with*special_char, 'M,M', 'M$M'}'::text[], we call
SELECT string_to_array(''ele'with*special_char', 'M"M', 'M$M'', ',')::text[]
Install check test cases also get updated.
Co-Authored-by: Jingyi Mei <jm...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib bug_minibatch_preprocessor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
commit 3a55cafd7fad1e87996b4584f7e0431529da7a52
Author: Jingyi Mei <jm...@...>
Date: 2018-05-23T23:29:54Z
Minibatch Preprocessing: fix dependent var with special character
JIRA:MADLIB-1237
Previously, minibatch processing would error out when the specified
dependent variable has special characters within its values. We
fixed this in two places:
1. in the query with WHERE condition, we use $$ to queto string instead
of ' ' to do string equals.
2. in the query with creating an array column, instead of using
SELECT '{ele'with*special_char, 'M,M', 'M$M'}'::text[], we call
SELECT string_to_array(''ele'with*special_char', 'M"M', 'M$M'', ',')::text[]
Install check test cases also get updated.
Co-Authored-by: Jingyi Mei <jm...@pivotal.io>
----
---
[GitHub] madlib issue #273: Minibatch Preprocessing: fix dependent var with special c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/273
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/513/
---
[GitHub] madlib pull request #273: Minibatch Preprocessing: fix dependent var with sp...
Posted by jingyimei <gi...@git.apache.org>.
Github user jingyimei closed the pull request at:
https://github.com/apache/madlib/pull/273
---
[GitHub] madlib issue #273: Minibatch Preprocessing: fix dependent var with special c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/273
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/490/
---
[GitHub] madlib issue #273: Minibatch Preprocessing: fix dependent var with special c...
Posted by jingyimei <gi...@git.apache.org>.
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/273
Will handle those in another PR, closing this one.
---
[GitHub] madlib issue #273: Minibatch Preprocessing: fix dependent var with special c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/273
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/494/
---
[GitHub] madlib issue #273: Minibatch Preprocessing: fix dependent var with special c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/273
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/514/
---