You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Serge! <ne...@mail.ru> on 2007/10/03 22:44:25 UTC
Re: wicket:interface, etc. in generated URLs
+1
Sounds like an important feature. We tried to get rid of wicket:xxx meat,
and we ended up copy-pasting UrlCompressingWebRequestProcessor. However,
stateless forms still provide bad URLs (and URL compression does not work
for them at all). Form URLs will not be easy to fix, as some encoding stuff
is done inside RequestTarget itself. Hacking this looks even more ugly now.
Of course we may go ahead with just patching Wicket sources...
Regards,
Sergey.
Al Maw wrote:
>
> Hi folks,
>
> Although some people don't really care what their URLs look like, lots
> of people do.
>
> If you use UrlCompressingWebCodingStrategy you can get the actual
> parameter values for interface/behaviour/etc. URLs looking pretty small
> and inoffensive.
>
> But the name is still something large, like "wicket:interface". I'm
> wondering if for 1.3 we could replace that with just:
>
> wicket:interface --> w:i
> wicket:behaviourId --> w:b
> wicket:bookmarkablePage --> w:p
> wicket:pageMapName --> w:m
>
> It'd make the URLs shorter and not really any less comprehensible (this
> stuff only really means anything to people who understand the internals
> anyway).
>
> It'd make things very marginally quicker (less string matching).
>
> In short, I can't really see any disadvantage to it, other than that it
> will break any existing bookmarks to non-mounted pages. I'm pretty sure
> that the upgrade from 1.2 to 1.3 breaks these anyway.
>
> It's a trivial fix (just update the constants in
> WebRequestCodingStrategy and a bunch of expected unit test results).
>
> What do people think?
>
> Regards,
>
> Al
>
> --
> Alastair Maw
> Wicket-biased blog at http://herebebeasties.com
>
>
--
View this message in context: http://www.nabble.com/wicket%3Ainterface%2C-etc.-in-generated-URLs-tf4142021.html#a13027542
Sent from the Wicket - Dev mailing list archive at Nabble.com.
Re: wicket:interface, etc. in generated URLs
Posted by Johan Compagner <jc...@gmail.com>.
that would be even better
or make a Jira issue with the things discussed in this thread
then i will look at asap.
Currently to busy debugging those stupid browsers :(
johan
On Feb 13, 2008 11:31 AM, Serge! <ne...@mail.ru> wrote:
>
> Hi,
>
> Are there any news or plans to implement it?
> Or maybe you just need someone to contribute a patch?
>
> Sergey.
> --
> View this message in context:
> http://www.nabble.com/wicket%3Ainterface%2C-etc.-in-generated-URLs-tp11782012p15453486.html
> Sent from the Wicket - Dev mailing list archive at Nabble.com<http://nabble.com/>
> .
>
>
Re: wicket:interface, etc. in generated URLs
Posted by Serge! <ne...@mail.ru>.
Hi,
Are there any news or plans to implement it?
Or maybe you just need someone to contribute a patch?
Sergey.
--
View this message in context: http://www.nabble.com/wicket%3Ainterface%2C-etc.-in-generated-URLs-tp11782012p15453486.html
Sent from the Wicket - Dev mailing list archive at Nabble.com.
Re: wicket:interface, etc. in generated URLs
Posted by Igor Vaynberg <ig...@gmail.com>.
just waiting for you to check it in johan!
-igor
On 10/3/07, Johan Compagner <jc...@gmail.com> wrote:
>
> there where a lot of +1
> are we going to change this?
> Or better let it be configureable?
>
> johan
>
>
>
> On 10/3/07, Serge! <ne...@mail.ru> wrote:
> >
> >
> > +1
> > Sounds like an important feature. We tried to get rid of wicket:xxx
> meat,
> > and we ended up copy-pasting UrlCompressingWebRequestProcessor. However,
> > stateless forms still provide bad URLs (and URL compression does not
> work
> > for them at all). Form URLs will not be easy to fix, as some encoding
> > stuff
> > is done inside RequestTarget itself. Hacking this looks even more ugly
> > now.
> > Of course we may go ahead with just patching Wicket sources...
> > Regards,
> > Sergey.
> >
> >
> > Al Maw wrote:
> > >
> > > Hi folks,
> > >
> > > Although some people don't really care what their URLs look like, lots
> > > of people do.
> > >
> > > If you use UrlCompressingWebCodingStrategy you can get the actual
> > > parameter values for interface/behaviour/etc. URLs looking pretty
> small
> > > and inoffensive.
> > >
> > > But the name is still something large, like "wicket:interface". I'm
> > > wondering if for 1.3 we could replace that with just:
> > >
> > > wicket:interface --> w:i
> > > wicket:behaviourId --> w:b
> > > wicket:bookmarkablePage --> w:p
> > > wicket:pageMapName --> w:m
> > >
> > > It'd make the URLs shorter and not really any less comprehensible
> (this
> > > stuff only really means anything to people who understand the
> internals
> > > anyway).
> > >
> > > It'd make things very marginally quicker (less string matching).
> > >
> > > In short, I can't really see any disadvantage to it, other than that
> it
> > > will break any existing bookmarks to non-mounted pages. I'm pretty
> sure
> > > that the upgrade from 1.2 to 1.3 breaks these anyway.
> > >
> > > It's a trivial fix (just update the constants in
> > > WebRequestCodingStrategy and a bunch of expected unit test results).
> > >
> > > What do people think?
> > >
> > > Regards,
> > >
> > > Al
> > >
> > > --
> > > Alastair Maw
> > > Wicket-biased blog at http://herebebeasties.com
> > >
> > >
> >
> > --
> > View this message in context:
> >
> http://www.nabble.com/wicket%3Ainterface%2C-etc.-in-generated-URLs-tf4142021.html#a13027542
> > Sent from the Wicket - Dev mailing list archive at Nabble.com.
> >
> >
>
Re: wicket:interface, etc. in generated URLs
Posted by Johan Compagner <jc...@gmail.com>.
there where a lot of +1
are we going to change this?
Or better let it be configureable?
johan
On 10/3/07, Serge! <ne...@mail.ru> wrote:
>
>
> +1
> Sounds like an important feature. We tried to get rid of wicket:xxx meat,
> and we ended up copy-pasting UrlCompressingWebRequestProcessor. However,
> stateless forms still provide bad URLs (and URL compression does not work
> for them at all). Form URLs will not be easy to fix, as some encoding
> stuff
> is done inside RequestTarget itself. Hacking this looks even more ugly
> now.
> Of course we may go ahead with just patching Wicket sources...
> Regards,
> Sergey.
>
>
> Al Maw wrote:
> >
> > Hi folks,
> >
> > Although some people don't really care what their URLs look like, lots
> > of people do.
> >
> > If you use UrlCompressingWebCodingStrategy you can get the actual
> > parameter values for interface/behaviour/etc. URLs looking pretty small
> > and inoffensive.
> >
> > But the name is still something large, like "wicket:interface". I'm
> > wondering if for 1.3 we could replace that with just:
> >
> > wicket:interface --> w:i
> > wicket:behaviourId --> w:b
> > wicket:bookmarkablePage --> w:p
> > wicket:pageMapName --> w:m
> >
> > It'd make the URLs shorter and not really any less comprehensible (this
> > stuff only really means anything to people who understand the internals
> > anyway).
> >
> > It'd make things very marginally quicker (less string matching).
> >
> > In short, I can't really see any disadvantage to it, other than that it
> > will break any existing bookmarks to non-mounted pages. I'm pretty sure
> > that the upgrade from 1.2 to 1.3 breaks these anyway.
> >
> > It's a trivial fix (just update the constants in
> > WebRequestCodingStrategy and a bunch of expected unit test results).
> >
> > What do people think?
> >
> > Regards,
> >
> > Al
> >
> > --
> > Alastair Maw
> > Wicket-biased blog at http://herebebeasties.com
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/wicket%3Ainterface%2C-etc.-in-generated-URLs-tf4142021.html#a13027542
> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>
>