You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/09 08:02:09 UTC
[GitHub] [inlong] Oneal65 opened a new pull request, #5429: [INLONG-XYZ][Sort] Add reporting metrics for kafka connector sink
Oneal65 opened a new pull request, #5429:
URL: https://github.com/apache/inlong/pull/5429
- Fixes #5377
### Motivation
Add reporting metrics for kafka connector sink
### Modifications
kafka connector
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Oneal65 commented on a diff in pull request #5429: [INLONG-5377][Sort] Add reporting metrics for kafka connector sink and audit SDK
Posted by GitBox <gi...@apache.org>.
Oneal65 commented on code in PR #5429:
URL: https://github.com/apache/inlong/pull/5429#discussion_r941948719
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaInLongOptions.java:
##########
@@ -22,8 +22,8 @@
import org.apache.flink.configuration.ConfigOptions;
/** Option utils for Kafka table source sink. */
-public class KafkaOptions {
- private KafkaOptions() {
+public class KafkaInLongOptions {
Review Comment:
OK, 3q
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #5429: [INLONG-5377][Sort] Add reporting metrics for kafka connector sink and audit SDK
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5429:
URL: https://github.com/apache/inlong/pull/5429#discussion_r941949799
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaInLongOptions.java:
##########
@@ -35,4 +35,10 @@ private KafkaOptions() {
.defaultValue(false)
.withDescription("Regard upsert delete as insert kind.");
+ public static final ConfigOption<String> INLONG_METRIC =
Review Comment:
inlong_metric is defined in connector-base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5429: [INLONG-5377][Sort] Add reporting metrics for kafka connector sink and audit SDK
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5429:
URL: https://github.com/apache/inlong/pull/5429#discussion_r941945293
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaInLongOptions.java:
##########
@@ -22,8 +22,8 @@
import org.apache.flink.configuration.ConfigOptions;
/** Option utils for Kafka table source sink. */
-public class KafkaOptions {
- private KafkaOptions() {
+public class KafkaInLongOptions {
Review Comment:
This refactoring doesn't make sense, it is recommended to keep it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5429: [INLONG-5377][Sort] Add reporting metrics for kafka connector sink and audit SDK
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5429:
URL: https://github.com/apache/inlong/pull/5429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org