[GitHub] jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations

[GitBox <gi...@apache.org>]

jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
URL: https://github.com/apache/accumulo/pull/476#discussion_r186493042
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -1776,6 +1776,41 @@
         <findbugs.excludeFilterFile>src/main/findbugs/exclude-filter.xml</findbugs.excludeFilterFile>
       </properties>
     </profile>
+    <profile>
+      <id>overrides</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-compiler-plugin</artifactId>
+            <configuration>
+              <compilerId>javac-with-errorprone</compilerId>
+              <forceJavacCompilerUse>true</forceJavacCompilerUse>
+              <source>1.8</source>
+              <target>1.8</target>
+              <compilerArgs>
+                <arg>-XepDisableAllChecks</arg>
+                <arg>-Xep:MissingOverride:ERROR</arg>
+                <arg>-XepExcludedPaths:.*/(proto|thrift|generated-sources)/.*</arg>
 
 Review comment:
   Unfortunately, yes. That flag only ignores generated code if certain annotations are in the code. The majority of our generated code does not have the annotation and were not ignored.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services