You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/02/15 19:48:43 UTC

[GitHub] [arrow] kou commented on pull request #34185: GH-34206: [C++] Don't let jemalloc defines affect unity builds

kou commented on PR #34185:
URL: https://github.com/apache/arrow/pull/34185#issuecomment-1431931617

   I think that we should not mix `memory_pool_jemalloc.cc` to other sources instead of `#undef`:
   
   ```diff
   diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
   index 6382fdfb3a..33cf3d396d 100644
   --- a/cpp/src/arrow/CMakeLists.txt
   +++ b/cpp/src/arrow/CMakeLists.txt
   @@ -243,6 +243,8 @@ set(ARROW_SRCS
    
    if(ARROW_JEMALLOC)
      list(APPEND ARROW_SRCS memory_pool_jemalloc.cc)
   +  set_source_files_properties(memory_pool_jemalloc.cc
   +                              PROPERTIES SKIP_UNITY_BUILD_INCLUSION ON)
    endif()
    
    append_avx2_src(util/bpacking_avx2.cc)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org