You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ro...@apache.org on 2019/09/12 09:36:21 UTC

[sling-ide-tooling] branch master updated: SLING-8572 - sling-ide-tooling is reported as broken but is actually successful

This is an automated email from the ASF dual-hosted git repository.

rombert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-ide-tooling.git


The following commit(s) were added to refs/heads/master by this push:
     new 143c3a9  SLING-8572 - sling-ide-tooling is reported as broken but is actually successful
143c3a9 is described below

commit 143c3a9e5139184ce7e32d7bfbeb19be2ef58f32
Author: Robert Munteanu <ro...@apache.org>
AuthorDate: Thu Sep 12 11:35:21 2019 +0200

    SLING-8572 - sling-ide-tooling is reported as broken but is actually successful
    
    Enable a couple of failing Windows tests to validate that reporting works
    as expected.
---
 cli/cli/src/test/java/org/apache/sling/ide/cli/impl/DirWatcherTest.java | 2 +-
 .../sling/ide/test/impl/JcrPartialCoverageAggregatesDeploymentTest.java | 2 +-
 .../sling/ide/test/impl/ui/sightly/SightlyAutocompletionTest.java       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cli/cli/src/test/java/org/apache/sling/ide/cli/impl/DirWatcherTest.java b/cli/cli/src/test/java/org/apache/sling/ide/cli/impl/DirWatcherTest.java
index be17894..c7e95cf 100644
--- a/cli/cli/src/test/java/org/apache/sling/ide/cli/impl/DirWatcherTest.java
+++ b/cli/cli/src/test/java/org/apache/sling/ide/cli/impl/DirWatcherTest.java
@@ -114,7 +114,7 @@ public class DirWatcherTest {
     @Test(timeout = 3000)
     public void deletedFile() throws IOException, InterruptedException {
         
-        assumeThat(System.getProperty("os.name"), not(containsString("Windows"))); // TODO - SLING-7596
+//        assumeThat(System.getProperty("os.name"), not(containsString("Windows"))); // TODO - SLING-7596
         
         File watchRoot = folder.newFolder();
         File subDir = new File(watchRoot, "subDir");
diff --git a/eclipse/eclipse-test/src/org/apache/sling/ide/test/impl/JcrPartialCoverageAggregatesDeploymentTest.java b/eclipse/eclipse-test/src/org/apache/sling/ide/test/impl/JcrPartialCoverageAggregatesDeploymentTest.java
index 18a3434..26f0fa8 100644
--- a/eclipse/eclipse-test/src/org/apache/sling/ide/test/impl/JcrPartialCoverageAggregatesDeploymentTest.java
+++ b/eclipse/eclipse-test/src/org/apache/sling/ide/test/impl/JcrPartialCoverageAggregatesDeploymentTest.java
@@ -250,7 +250,7 @@ public class JcrPartialCoverageAggregatesDeploymentTest {
     
     @Test
     public void deployNodeWithContentXmlInParentFolder() throws Exception {
-        assumeThat(System.getProperty("os.name"), not(containsString("Windows"))); // TODO - SLING-7596
+//        assumeThat(System.getProperty("os.name"), not(containsString("Windows"))); // TODO - SLING-7596
 
         wstServer.waitForServerToStart();
 
diff --git a/eclipse/eclipse-test/src/org/apache/sling/ide/test/impl/ui/sightly/SightlyAutocompletionTest.java b/eclipse/eclipse-test/src/org/apache/sling/ide/test/impl/ui/sightly/SightlyAutocompletionTest.java
index 60263e2..d6b914c 100644
--- a/eclipse/eclipse-test/src/org/apache/sling/ide/test/impl/ui/sightly/SightlyAutocompletionTest.java
+++ b/eclipse/eclipse-test/src/org/apache/sling/ide/test/impl/ui/sightly/SightlyAutocompletionTest.java
@@ -62,7 +62,7 @@ public class SightlyAutocompletionTest {
     @Test
     public void tagNameAutocompletion() throws Exception {
         
-        assumeThat(System.getProperty("os.name"), not(containsString("Windows"))); // TODO - SLING-7596
+        //assumeThat(System.getProperty("os.name"), not(containsString("Windows"))); // TODO - SLING-7596
 
         List<String> proposals = new AutocompletionCallable() {
             @Override