[GitHub] [nifi] bbende commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…

[GitBox <gi...@apache.org>]

bbende commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#issuecomment-513245818
 
 
   Been testing this the past couple of days and had two comments...
   
   1) I think there is some inconsistency with the authorization hierarchy for an individual context (currently has parent of parameter-contexts, with parent of controller) vs the parameter-contexts resource (currently no parent).
   
   2) I tested all of the parameter reference examples from the feature proposal... 
   
   When using a property that does not support EL, the results matched the expected results on the wiki.
   
   When using a property that does support EL, there were a few weird results related to escaping.
   
   Using a context with a parameter name `param1` having a value of `param1-dev`:
   
   ```
   ###{param1} -> ###param1-dev (should be #param1-dev)
   ####{param1} -> ####{param1}####{param1}  (should be ##{param1})
   #####{param1} -> #####param1-dev (should be ##param1-dev)
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services